Vscode-intelephense: Add configuration option to enable/disable formatter

Created on 9 Sep 2017  Â·  5Comments  Â·  Source: bmewburn/vscode-intelephense

From @jjtriff bmewburn/intelephense#53

Hello:

I was trying to modify your code:

1. adding a configuration setting in package.json:
"intelephense.formatter.enable": { "type": "boolean", "default": true, "description": "Enable debug logging." }
2.  and asking for it before doing
this._registeredHandlers.set( DocumentFormattingRequest.type.method, new LanguageFeature<TextDocumentRegistrationOptions>((options) => this.createDocumentFormattingProvider(options)) );
inside client.ts file.

but I'm not sure what will I get when doing
Workspace.getConfiguration(this._id)

so I was trying to debug your extension, but I wasn't able to do it. Didn't make vscode to run in debug extension mode.

BTW: I think I'm mixing here code from two different github repos.

What I'm trying to ask is for a short guide to clone your repo, edit it, debug it, push it, and make a pull request.

Zanks in advanced

PS: this has to do with #46, so I can keep working using your wonderful extension

Most helpful comment

resolved in v0.8.0 intelephense.formatProvider.enable

All 5 comments

Thanks for your effort on this, your pull request is welcome. I followed this guide when first creating this extension . It gives a pretty good summary and describes how to debug.

The basic workflow is something like this:

  1. Fork this repo using github UI to get a copy in your own account
  2. git clone <URL> your github copy to your dev machine.
  3. git checkout -b <YOUR_BRANCH_NAME> to create and checkout a new branch to do your work in.
  4. Do your edits and debugging.
  5. git push to your github copy
  6. create a pull request using github UI.

Would really love to see this happen. Currently it some times steps on php-cs-fixer extension and it would be great to just have an option to disable the formatter.

resolved in v0.8.0 intelephense.formatProvider.enable

Zanks @bmewburn , I really REALLY meant to give you a hand on this one, but my job (and having no internet back at home, I'm in Cuba) got me very busy. Keep up the good work B-)!!

If someone else will search for this feature… config option was changed a bit, now it's : intelephense.format.enable

Was this page helpful?
0 / 5 - 0 ratings