Visualstudio: Inline comment margin in editor with Dark color theme

[laurentkempe]

Hello! Loving this new feature! The only issue I see at the moment is that the text is hardly readable with the Dark color theme, see the screenshot

• GitHub Extension for Visual Studio version: 2.5.2.2566
• Visual Studio version: 15.7.1

[jcansdale]

Thanks for the heads up. I've been using light theme recently. I should go dark gain.

This control really needs some love from @donokuda!
https://github.com/github/VisualStudio/blob/master/src/GitHub.InlineReviews/Views/PullRequestFileMarginView.xaml

[jcansdale]

This CheckBox/TextBlock is the biggest problem theme-wize at the moment:
https://github.com/github/VisualStudio/blob/master/src/GitHub.InlineReviews/Views/PullRequestFileMarginView.xaml#L21

[laurentkempe]

I am not sure I would display again the name of the file, it is a duplicated information from the VS tab.
Maybe just a comment icon like you have which would also be the check/toggle!

[jcansdale]

This is going to be completely reworked. There'll be options like view changes in local commits, view changes in PR and view comments (fresh and stale). That kind of thing. Lots to think about!