Viewers: DICOM tag viewer does not sort entries for SEG

[fedorov]

It appears that entries for SEG are not sorted

I thought this is because of the presence of sequences, but they seem to be sorted for SRs...

[pieper]

Can you clarify what part is not sorted? At a glance it seems that the tags are sorted by group and then element within each nesting level. Or do I miss something?

[fedorov]

Well, maybe they are indeed sorted, but I don't know the sort order is. It is not obvious to me.

Here's where group 0002 is in SEG tag lilst:

And for the CT instance is it at the very top (consistent with other tag viewers):

[pieper]

I can't tell from your seg screenshot what's above the sequence. Is it group 0000?

[fedorov]

it is group 5200

[pieper]

Okay, yes, that's clearly incorrect.

[JamesAPetts]

Interesting.

I'm actually just iterating through the props, which for the most part are adding in the right order, which seemed largely fine. But the way we compose SEGs mean we add tags in different times. All groups will be fine, so I think we just need to sort the top level.

[fedorov]

Nitpick: can you also add a space between ">" and "("?

[fedorov]

I am not going to try to trace back the version of the viewer used in IDC to this one, but I see that this issue was fixed ~20 days ago, so I am going to take an educated guess it is in IDC. If that guess is accurate, the issue has not been fixed:

[JamesAPetts]

After some discussion on slack it seems this is either fixed, or we have issues on certain SEGs.

@fedorov will check if he can reproduce.

[fedorov]

Can't reproduce it, must have been fixed! 👍