Viewers: Add Arrow Annotate Tool

Created on 2 Sep 2019  路  3Comments  路  Source: OHIF/Viewers

Add Arrow Annotate tool as we had in Meteor version. See http://viewer-legacy.ohif.org

Story

Most helpful comment

@galelis, here is some additional information about how to set configuration in cornerstone-tools@3 and beyond: https://github.com/cornerstonejs/cornerstoneTools/issues/1105#issuecomment-542462775

For the time being, you'll need to update the ArrowAnnotateTool's configuration in two places:

  • <root>/platform/viewer/src/appExtensions/MeasurementsPanel/init.js
  • <root>/extensions/cornerstone/src/init.js

These are the preRegistration hooks for the cornerstone and measurements panel extensions.

We don't have a great mechanism in place to show dialogs or modals from extensions. One option is to create a dialogProvider like this snackbarProvider:

And then we update our extensions to receive exposed methods for what are essentially services. This is something @JamesAPetts and I have lightly talked about, but we haven't landed on the best way to expose services / state to extensions. The current "connect" approach is a bit rough as is, and I'm cautious to continue down that road.

This is something we can discuss or pair on if you need more guidance. When you draft a PR, please tag me ^_^

All 3 comments

@galelis, here is some additional information about how to set configuration in cornerstone-tools@3 and beyond: https://github.com/cornerstonejs/cornerstoneTools/issues/1105#issuecomment-542462775

For the time being, you'll need to update the ArrowAnnotateTool's configuration in two places:

  • <root>/platform/viewer/src/appExtensions/MeasurementsPanel/init.js
  • <root>/extensions/cornerstone/src/init.js

These are the preRegistration hooks for the cornerstone and measurements panel extensions.

We don't have a great mechanism in place to show dialogs or modals from extensions. One option is to create a dialogProvider like this snackbarProvider:

And then we update our extensions to receive exposed methods for what are essentially services. This is something @JamesAPetts and I have lightly talked about, but we haven't landed on the best way to expose services / state to extensions. The current "connect" approach is a bit rough as is, and I'm cautious to continue down that road.

This is something we can discuss or pair on if you need more guidance. When you draft a PR, please tag me ^_^

@galelis, I'm unassigning this from you and assigning @igoroctaviano. His in-progress work should make it easier to knock this out.

@dannyrb this issue can be closed?

Was this page helpful?
0 / 5 - 0 ratings

Related issues

TZubiri picture TZubiri  路  3Comments

christianvargasforero picture christianvargasforero  路  3Comments

ranasrule picture ranasrule  路  4Comments

christianvargasforero picture christianvargasforero  路  4Comments

rlaxodnjs199 picture rlaxodnjs199  路  3Comments