Viewers: About box reports incorrect version number

Created on 1 Sep 2020  路  6Comments  路  Source: OHIF/Viewers

Bug Report

Describe the Bug

The about box has contradictory information. As shown below, the version number is old but this should be a build of the current master branch.

image

What steps can we follow to reproduce the bug?

Open viewer.ohif.org (or other build) and go to Options->About.

My guess is that the version is based on when the build directory was first initialized and doesn't get updated on new builds.

Awaiting Reproduction Community candidate Triage

Most helpful comment

Oof. Not a great comment for me to make before a long stint of vacation. Blocking off some time today to whip up a quick something.

All 6 comments

Discussed and agreed to query idcGitVersion.txt that is available in top-level IDC deployment and show that in About. This will be done in fork, so @pieper will create an issue under fork to do this?

After a quick look at the webpack configuration for OHIF I think I'm not the best person to do this, or at least it would take me longer.

I believe all we need to do is add this plugin: https://www.npmjs.com/package/git-revision-webpack-plugin

and then make sure it is available to use in the dialogs. I think this would be valuable for any ohif deployment.

@JamesAPetts or @dannyrb could you help?

Mailto tag is fixed.

About box is more tricky and I'm seeing what the OHIF team can suggest.

From earlier conversation with @dannyrb:

image

Oof. Not a great comment for me to make before a long stint of vacation. Blocking off some time today to whip up a quick something.

Thanks @dannyrb! The intent was not to put you on the spot, but to pull together all the pieces of information related to this issue. We would most definitely appreciate your help though!

Was this page helpful?
0 / 5 - 0 ratings

Related issues

szwang-wthealth picture szwang-wthealth  路  3Comments

Diegovictorbr picture Diegovictorbr  路  4Comments

ohif-bot picture ohif-bot  路  3Comments

trung1704ptit picture trung1704ptit  路  4Comments

MuriloSchaefer picture MuriloSchaefer  路  3Comments