Vega: Nest transform generate signal does not update data

Created on 11 Apr 2018  路  5Comments  路  Source: vega/vega

The code in PR seems to indicate that setting generate parameter for the nest transform via a signal does not regenerate the data pipeline.

Repo: open PR's vega code, and click the checkbox. Also try to set the initial value to false, and click the checkbox.

bug

Most helpful comment

Yes, I'm well aware of the negative effects of non-backwards-compatible changes. Don't worry 馃榿

All 5 comments

Thanks! I fixed this issue as part of a larger refactoring of hierarchy management and treelink generation. The latest is in master in the vega-hierarchy repo. However, the updates include changes to the parameter signatures of some of the transforms, so I'm batching them for a later Vega release that includes some more significant changes for, among other things, parity with D3 v5.

I'll close this issue once the changes have been released.

@jheer changes to the parameter signatures means a breaking change for all existing users of Vega graphs. Please make it backward compatible, otherwise we won't be able to use it - imagine breaking tens of thousands of graphs with the upgrade -- noone would get the new version, as the upgrade cost of a big platform instantly skyrockets.

P.S. Vega could still show a warning when older parameter style is being used, e.g. "param X has been renamed to param Y for trtansform Z, please update your graph". Or just support both names. Thx for all your work on this!

Yes, I'm well aware of the negative effects of non-backwards-compatible changes. Don't worry 馃榿

Fixed in v4.0.0-rc.1.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

jheer picture jheer  路  5Comments

malhotrachetan picture malhotrachetan  路  5Comments

arvind picture arvind  路  5Comments

sonlichao picture sonlichao  路  4Comments

mattijn picture mattijn  路  3Comments