Uppy: S3 Multipart: Second retry after offline mode breaks file upload (parts duplicate)

Created on 17 Jun 2020  路  3Comments  路  Source: transloadit/uppy

When @uppy/aws-s3-multipart is used,

  • start upload of a file which requires multiple parts upload (e.g. 100Mb)
  • wait for at least one part to upload
  • disconnect internet connection (e.g. choose Offline in Chrome's Dev Tools / Network)
  • restart upload
  • wait for at least one part to upload
  • disconnect internet connection (e.g. choose Offline in Chrome's Dev Tools / Network)
  • restart upload
    When all parts are uploaded, the upload completion request fails with "The list of parts was not in ascending order. Parts must be ordered by part number." error from S3.
    The reason is that one of the parts is present two times in the list of the parts sent to the complete endpoint.
AWS S3 Bug

Most helpful comment

I've created two related pull requests, both fixing the issue.

2325 is a single line change fixing the bug

2326 is dropping the parts storing in the state which seems unnecessary

All 3 comments

I've created two related pull requests, both fixing the issue.

2325 is a single line change fixing the bug

2326 is dropping the parts storing in the state which seems unnecessary

@yaegor @goto-bus-stop Any word on getting a release cut so I can npm install this fix?

I got this error today because one of the parts was duplicated but this was supposed to be fixed with @yaegor changes on https://github.com/transloadit/uppy/pull/2326

I have the latest version of Uppy and the user was using Safari on Mac 10.15

Any ideas?

Was this page helpful?
0 / 5 - 0 ratings