Unitystation: Fix Bans | Make it IP-Ban

Created on 8 Feb 2020  路  4Comments  路  Source: unitystation/unitystation

This is probably something we should get onto

Bans do not really ban the person and basically act as a glorified kick

Steps to Reproduce

Please enter the steps to reproduce the bug or behaviour:

  1. Be Admin
  2. Ban person
High Admin Feature

Most helpful comment

https://github.com/unitystation/unitystation/blob/develop/UnityProject/Assets/Scripts/Managers/PlayerList.Admin.cs

Looking at the above it looks to me that banning is based on a Users Id, which I believe is from the data store, so if anything this should be a pretty solid ban for that users account.

Probably best idea to stick to the HWID. No need for the addition of an IP as who doesn't use VPN's in this day and age (except for kids).
https://docs.unity3d.com/ScriptReference/SystemInfo-deviceUniqueIdentifier.html

Can't get the game to actually work so me testing this is not going to work out for now, anyone else wants to make these edits feel free, will come back when I can get things on my end to work. Even unity is being a bit of a pain. Thought a restart and reinstall would settle things but its deeper than that.

All 4 comments

Suggest adding also a hwid ban

Will take a look at this when I get a mo

https://github.com/unitystation/unitystation/blob/develop/UnityProject/Assets/Scripts/Managers/PlayerList.Admin.cs

Looking at the above it looks to me that banning is based on a Users Id, which I believe is from the data store, so if anything this should be a pretty solid ban for that users account.

Probably best idea to stick to the HWID. No need for the addition of an IP as who doesn't use VPN's in this day and age (except for kids).
https://docs.unity3d.com/ScriptReference/SystemInfo-deviceUniqueIdentifier.html

Can't get the game to actually work so me testing this is not going to work out for now, anyone else wants to make these edits feel free, will come back when I can get things on my end to work. Even unity is being a bit of a pain. Thought a restart and reinstall would settle things but its deeper than that.

done

Was this page helpful?
0 / 5 - 0 ratings

Related issues

nuke-makes-games picture nuke-makes-games  路  6Comments

DooblyNoobly picture DooblyNoobly  路  7Comments

krille90 picture krille90  路  4Comments

Raptorizer picture Raptorizer  路  8Comments

Destrolaric picture Destrolaric  路  7Comments