Unitystation: Shutters should be already closed from start

Created on 14 Jan 2019  路  4Comments  路  Source: unitystation/unitystation

Description

Currently shutters always start opened and will close after a few seconds (it plays the normal closing animation). This affects things like Atmos, e.g. if the shutter is next to a space tile, the gases from the room will be drained at round start.

Category

BUG

Detailed Bug Report

Desired behaviour is that the shutters already start closed (like doors) and don't play the closing animation. Beware that shutters could also start opened, when the "IsClosed"-Flag the "RegisterDoor"-script is not selected.

Steps to Reproduce

Please enter the steps to reproduce the bug or behaviour:

  1. Look in scene editor at a shutters
  2. press Play
  3. See how the shutters start opened and will close after a few seconds
Good First Issue In Progress Bug

Most helpful comment

Changes to ShutterController Animator

FROM

image

TO

image

The new 04_shutterClosed and 04_shutterOpen are determined at game start by the IsClosed empty state, which checks the value of close parameter and sets the initial state of the door (open or closed) corresponding to the "IsClosed" flag from "RegisterDoor".

This is made possible by triggering the shutter SetState() (through Trigger method) at the object's creation.

image

I will provide use case examples in PR. I am currently documenting these changes and doing a bit of cleanup

All 4 comments

didn't know we had working shutters (but apparently we do)
Also cargo shutter button is invisible from inside due to mapping error:
default
default

I've got this nearly complete. Assign?

all yours

Changes to ShutterController Animator

FROM

image

TO

image

The new 04_shutterClosed and 04_shutterOpen are determined at game start by the IsClosed empty state, which checks the value of close parameter and sets the initial state of the door (open or closed) corresponding to the "IsClosed" flag from "RegisterDoor".

This is made possible by triggering the shutter SetState() (through Trigger method) at the object's creation.

image

I will provide use case examples in PR. I am currently documenting these changes and doing a bit of cleanup

Was this page helpful?
0 / 5 - 0 ratings

Related issues

DooblyNoobly picture DooblyNoobly  路  4Comments

kdkaergaard picture kdkaergaard  路  4Comments

Dropgunner picture Dropgunner  路  3Comments

ThatDan123 picture ThatDan123  路  3Comments

Ornias1993 picture Ornias1993  路  7Comments