Trinitycore: aggro chaining

[Aokromes]

Description:

since few days ago (max 15 days) some mobs are chaining agro to far from previous distances
before 1st icc boss you can see the same.

Expected behaviour:

you can do gundrak without pull 3 rinos at once.

Steps to reproduce the problem:

1. tele gundrak
2. go the stairs before last boss
3. kill front rino.
4. try to kill side rinos without agro the rest
5. notice you pull 2 or 3 rinos instead one.

Branch(es):

3.3.5

TC rev. hash/commit:

2d6237f06ae6

Operating system: debian 10 x64.

[jackpoz]

anyone would like to spot which commit caused this by testing different versions of TC ? one can download binaries from appveyor

[Jildor]

I can reproduce it in old TC rev about 2017 and in latest rev, but I can't reproduce in rev from a month ago.
Is it really a bug or was it a bug a month ago?

[jackpoz]

Some tests:

• d52acf1b72c702637d10cce19e121435308e8410 : 🔴 🐞 👎
• a46c835ed1b498d4670c149a9f3ca31ea44eb35f : 🔴 🐞 👎
• feaaa595cae735bb6093b24a88562c27b2723cfe : 🟢 👍
• 062c55f1ab9c84396ce5b054945f5a908e3a354f : 🟢 👍
• 9e8915eaac70c0fd6dab98beeaddef59f2741b42 : 🟢 👍

[offl]

I tested on aba07047a05fc46e5904f3084b6351850188f9b4 and didn't noticed any problem
Maybe https://github.com/TrinityCore/TrinityCore/commit/9f0b5526f070abc7460a31ea599e780f164a36b2 or https://github.com/TrinityCore/TrinityCore/commit/2d6237f06ae6b74bb8ebfe745d8c0f1ce440e2fe is the cause?

[Jildor]

But the current (and in rev about 2017) behaviour is wrong (you can pull 2 rinos)? Or rev from more than two weeks ago behaviour is wrong(you can pull 1 rino)? Any proof?

[offl]

The issue is CallAssistance radius is changed to 15 yards (or more) from 10 yards for certain creatures
Of course current behavior is wrong because CONFIG_CREATURE_FAMILY_ASSISTANCE_RADIUS is ignored

[Jildor]

happens after 39a436bd658790d39d3cfa64e18f49544475dfe3 / 0d152e932cdd986f62ae22bd9fc40569892a2453
I tried to revert these 2 commits and I can't reproduce it

[offl]

@Ovahlord take a look please

[Aokromes]

strange, i tried d52acf1b72c7 (39a436b-1) and it agroed.

[Ovahlord]

This smells like some hacky bullshit mechanic is going wild in that case. Gonna check Gundrak.

[jackpoz]

@Jildor could you test the issue on https://github.com/TrinityCore/TrinityCore/commit/d52acf1b72c702637d10cce19e121435308e8410 with a brand new TDB too (for that commit ofc) ?

[Jildor]

I tested with clean TC rev https://github.com/TrinityCore/TrinityCore/commit/d52acf1b72c702637d10cce19e121435308e8410 and clean tdb (TDB 335.20082) and I can't reproduce it, after that, I updated to https://github.com/TrinityCore/TrinityCore/commit/0d152e932cdd986f62ae22bd9fc40569892a2453 (next 2 commits) and I can reproduce it.
I don't know what aokromes will have tried, but the issue is caused by spell focusing commits

.gm on
.go xyz 1844.237183 743.010559 135.908661 604
.die first center rino and drakkari raiders
.gm off
select another rino and use some taunt spell

[Aokromes]

i used a warlock or a mage with direct damage spells.

[github-actions[bot]]

24018b7a74ec8e68e43895e0e57f6397f59ea890