Trinitycore: [Icecrown Citadel] Trash mobs without SmartScripts

[ConradBunton]

Trash NPC hasn't theirs casts

They just fight in melee mode, no specific spell

Steps to reproduce the problem:
Just fight with some trash mob like:

NPC 37127 (Cast 69269 71203 71270 72274)
NPC 37132 (Cast 71208 71257 71258)
NPC 37133 (Cast 41056 41057 71208)
NPC 37134 (Cast 71208 71251 71252)

Branch(es): 3.3.5

TC rev. hash/commit: 39b20b4431a1a67446e9cc4c2221fd42cc907291

TDB version: 335.62

Operating system: Win server 2008

[Keader]

All trash mobs needs SAI in ICC :)

[ConradBunton]

I'm not a dev. So, when I see a bug, I just say it with all informations that I can give.

[Aokromes]

I remember a ticket about this, but hard to find with such generic keywords

[ConradBunton]

At his time, I scripted them on Eluna engine (LUA code), but it's not really the best solution.
Perhaps a C++ code will be better, but it's not my speciality.

[Keader]

No need a c++ script for it, just smart_scripts in DB :)

[ConradBunton]

And that SAI is ?

[Keader]

Smart Scripts xD

[ConradBunton]

...

[malcrom]

Needs some timing info. Need to know if spells are linked to heroic spells. I'm doubtful if all are scripted. Please test.

-- Ymirjar Frostbinder SAI
SET @ENTRY := 37127;
UPDATE `creature_template` SET `AIName`="SmartAI" WHERE `entry`=@ENTRY;
DELETE FROM `smart_scripts` WHERE `entryorguid`=@ENTRY AND `source_type`=0;
INSERT INTO `smart_scripts` (`entryorguid`,`source_type`,`id`,`link`,`event_type`,`event_phase_mask`,`event_chance`,`event_flags`,`event_param1`,`event_param2`,`event_param3`,`event_param4`,`action_type`,`action_param1`,`action_param2`,`action_param3`,`action_param4`,`action_param5`,`action_param6`,`target_type`,`target_param1`,`target_param2`,`target_param3`,`target_x`,`target_y`,`target_z`,`target_o`,`comment`) VALUES
(@ENTRY,0,1,0,0,0,100,30,xxxx,xxxx,xxxx,xxxx,11,71270,0,0,0,0,0,1,0,0,0,0,0,0,0,"Ymirjar Frostbinder - In Combat - Cast 'Arctic Chill'"),
(@ENTRY,0,2,0,0,0,100,30,xxxx,xxxx,xxxx,xxxx,11,71274,0,0,0,0,0,1,0,0,0,0,0,0,0,"Ymirjar Frostbinder - In Combat - Cast 'Frozen Orb'"),
(@ENTRY,0,3,0,0,0,100,30,xxxx,xxxx,xxxx,xxxx,11,69929,0,0,0,0,0,5,0,0,0,0,0,0,0,"Ymirjar Frostbinder - In Combat - Cast 'Spirit Stream'"),
(@ENTRY,0,4,0,0,0,100,30,xxxx,xxxx,xxxx,xxxx,11,71306,0,0,0,0,0,26,50000,0,0,0,0,0,0,"Ymirjar Frostbinder - In Combat - Cast 'Twisted Winds'"),
(@ENTRY,0,5,0,6,0,100,28,0,0,0,0,11,71203,0,0,0,0,0,18,50000,0,0,0,0,0,0,"Ymirjar Frostbinder - On Death - Cast 'Soul Feast'");

-- Ymirjar Battle-Maiden
SET @ENTRY := 37132;
UPDATE `creature_template` SET `AIName`="SmartAI" WHERE `entry`=@ENTRY;
DELETE FROM `smart_scripts` WHERE `entryorguid`=@ENTRY AND `source_type`=0;
INSERT INTO `smart_scripts` (`entryorguid`,`source_type`,`id`,`link`,`event_type`,`event_phase_mask`,`event_chance`,`event_flags`,`event_param1`,`event_param2`,`event_param3`,`event_param4`,`action_type`,`action_param1`,`action_param2`,`action_param3`,`action_param4`,`action_param5`,`action_param6`,`target_type`,`target_param1`,`target_param2`,`target_param3`,`target_x`,`target_y`,`target_z`,`target_o`,`comment`) VALUES
(@ENTRY,0,1,0,0,0,100,30,xxxx,xxxx,xxxx,xxxx,11,71258,0,0,0,0,0,1,0,0,0,0,0,0,0,"Ymirjar Battle-Maiden - In Combat - Cast 'Adrenaline Rush'"),
(@ENTRY,0,2,0,9,0,100,30,0,5,xxxx,xxxx,11,71257,0,0,0,0,0,2,0,0,0,0,0,0,0,"Ymirjar Battle-Maiden - Within 0-5 Range - Cast 'Barbaric Strike'"),
(@ENTRY,0,3,0,6,0,100,28,0,0,0,0,11,71203,0,0,0,0,0,18,50000,0,0,0,0,0,0,"Ymirjar Battle-Maiden - On Death - Cast 'Soul Feast'");

-- Ymirjar Warlord
SET @ENTRY := 37133;
UPDATE `creature_template` SET `AIName`="SmartAI" WHERE `entry`=@ENTRY;
DELETE FROM `smart_scripts` WHERE `entryorguid`=@ENTRY AND `source_type`=0;
INSERT INTO `smart_scripts` (`entryorguid`,`source_type`,`id`,`link`,`event_type`,`event_phase_mask`,`event_chance`,`event_flags`,`event_param1`,`event_param2`,`event_param3`,`event_param4`,`action_type`,`action_param1`,`action_param2`,`action_param3`,`action_param4`,`action_param5`,`action_param6`,`target_type`,`target_param1`,`target_param2`,`target_param3`,`target_x`,`target_y`,`target_z`,`target_o`,`comment`) VALUES
(@ENTRY,0,1,0,0,0,100,30,xxxx,xxxx,xxxx,xxxx,11,41056,0,0,0,0,0,1,0,0,0,0,0,0,0,"Ymirjar Warlord - In Combat - Cast 'Whirlwind'"),
(@ENTRY,0,2,0,6,0,100,16,0,0,0,0,11,71208,0,0,0,0,0,7,0,0,0,0,0,0,0,"Ymirjar Warlord - In Combat - Cast 'Taste of Blood'"), -- Spell 213738 for 7.X
(@ENTRY,0,3,0,6,0,100,28,0,0,0,0,11,71203,0,0,0,0,0,18,50000,0,0,0,0,0,0,"Ymirjar Warlord - On Death - Cast 'Soul Feast'");

-- Ymirjar Huntress
SET @ENTRY := 37134;
UPDATE `creature_template` SET `AIName`="SmartAI" WHERE `entry`=@ENTRY;
DELETE FROM `smart_scripts` WHERE `entryorguid`=@ENTRY AND `source_type`=0;
INSERT INTO `smart_scripts` (`entryorguid`,`source_type`,`id`,`link`,`event_type`,`event_phase_mask`,`event_chance`,`event_flags`,`event_param1`,`event_param2`,`event_param3`,`event_param4`,`action_type`,`action_param1`,`action_param2`,`action_param3`,`action_param4`,`action_param5`,`action_param6`,`target_type`,`target_param1`,`target_param2`,`target_param3`,`target_x`,`target_y`,`target_z`,`target_o`,`comment`) VALUES
(@ENTRY,0,1,0,0,0,100,30,xxxx,xxxx,xxxx,xxxx,11,71251,64,0,0,0,0,2,0,0,0,0,0,0,0,"Ymirjar Huntress - In Combat CMC - Cast 'Rapid Shot'"),
(@ENTRY,0,2,0,0,0,100,30,xxxx,xxxx,xxxx,xxxx,11,71252,0,0,0,0,0,2,0,0,0,0,0,0,0,"Ymirjar Huntress - In Combat - Cast 'Volley'"),
(@ENTRY,0,3,0,1,0,100,25,1000,1000,1000,1000,11,71705,0,0,0,0,0,1,0,0,0,0,0,0,0,"Ymirjar Huntress - In Combat - Cast 'Summon Warhawk'"),
(@ENTRY,0,4,0,6,0,100,16,0,0,0,0,11,71208,0,0,0,0,0,7,0,0,0,0,0,0,0,"Ymirjar Huntress - In Combat - Cast 'Taste of Blood'"), -- Spell 213738 for 7.X
(@ENTRY,0,5,0,6,0,100,28,0,0,0,0,11,71203,0,0,0,0,0,18,50000,0,0,0,0,0,0,"Ymirjar Huntress - On Death - Cast 'Soul Feast'");

[Keader]

Some implemented here 394b119664bc16dc5376f1404925b6d0b5a26876
Still missing creatures as f* xD