Trenchbroom: Clicking on a group with hidden brushes in it behaves weirdly

[bstordeur]

Hidden brushes inside a groupe are still taken into account for selecting that group when clicking on stuff.
Example here, I hide the brushes inside the group on the right, but I can't always select the brush behind the group instead of the group itself.

System Information

TrenchBroom 2019.5 on Win7

Expected Behavior

The hidden brushes should not be taken into account when clicking on where they are when visible.

Steps to Reproduce

Check example map :
grouphideselection.zip
Enter the group on the right.
Hide the brushes in it.
Exit the group.
Try to select the brush behind them, notice it'll select the group if you click somewhere a hidden brush is.

[ericwa]

Looked at this a bit. Group::doPick does its own version of picking logic on the group children using Group::doIntersectWithRay/IntersectNodeWithRayVisitor, which can hit hidden brushes. https://github.com/kduske/TrenchBroom/issues/2743 is caused by another behaviour difference between picking and intersectWithRay() api's (Entity::doIntersectWithRay doesn't trace against the model tris). Another problem with the current setup is, from what I can tell, if you put large sections of your map into Groups you're sidestepping the AABB tree, since IntersectNodeWithRayVisitor will visit all children of a group.

My hunch is, the Groups should not respond to doPick and not be inserted in the AABB tree (which is how brush entities behave too). The logic where clicking on an object in a group selects the group could be a layer of UI processing on top of the picking results. Not sure if this matches what you hand in mind for picking though?

[bstordeur]

This is actually more annoying than I thought.
You can apply a texture to the face of a hidden brush if it's in a group, instead of on the visible face behind it you're actually clicking on.

[ericwa]

Have a fix in progress..
Huh - didn't realize you could Alt-click apply textures to brushes inside a closed group. For the normal, non-hidden case, it seems harmless but it's also inconsistent because most/all other actions are blocked on brushes in closed groups.

[kduske]

I think it's ok to leave that as a "feature" ;-)

[bstordeur]

Yes, please don't remove that, it's very handy to be able to do it!