Transgui: The customized shortcut key (introduced in #924) result in blank panes in 5.13 on Windows 10 1709
In 5.13, customized shortcut keys like "Alt + P"(Info Pane - Peers Tab), "Alt + G"(Info Pane - General Tab) and so on introduced in https://github.com/transmission-remote-gui/transgui/issues/924 result in blank pane when these pane are focused by these shortcut keys, but focusing them by mouse clicking or "Tab -> arrow key" works fine.
kissglay
All 11 comments
And in 5.12 that shortcuts works fine?
antekgla
on 7 Jan 2018
Yes. In 5.12 it's fine.
Now in 5.13.0, when hit "Alt + P", it's what it looks like:
kissglay
on 7 Jan 2018
What is your system?
Windows, Linux, Mac?
antekgla
on 7 Jan 2018
Windows 10 1709
kissglay
on 7 Jan 2018
It works fine in my W7....
Let me find a W10 machine and I do some more testing....
antekgla
on 7 Jan 2018
Well after some testing I can see this:
1.- With the current source code compiled in Lazarus 1.6 works Ok in W7 & W10.
2.- With the current source code compiled in Lazarus 1.8 the shortcuts works but the behavior is as @kissglay say in W7 & W10.
So to conclude the problem is Lazarus 1.8 maybe @leonsoft-kras & @PeterDaveHello have to view if using Lazarus 1.8 is a good choice.
antekgla
on 7 Jan 2018
I'm trying to fix this but at push a commit (with Desktop Github in Windows) this error came up.
@leonsoft-kras or @PeterDaveHello can solve this?
PD: I隆m trying to commit to master branch
antekgla
on 11 Jan 2018
@antekgla Try to use another branch or use pull request?
PeterDaveHello
on 12 Jan 2018
@antekgla Try to use another branch or use pull request?
@PeterDaveHello or you ( or @leonsoft-kras ) can give me access to push to the master branch.
antekgla
on 12 Jan 2018
@antekgla I set you the owner of the whole project now, but personally, I still strongly recommend you to push to another branch first, let the CI test all the build process, and even let the issuer/reporter to use the build artifacts from CI to test if the results are as expect, this can help the whole project reliability and quality 馃槃
PeterDaveHello
on 13 Jan 2018
@PeterDaveHello Ok, thanks for the access.
I push this last commit directly to the master branch because I have already done it in my Github Desktop and frankly I dont know how to undo it. Only have pending the push.
In the future I will try to make the push to another branch ( I have to create it first?)
Regarding to the subject of this Issue I want to thank to the nice people of Lazarus forum specially to Getmem what nicely give me the answer to this issue, remarking what the problem is what in Lazarus 1.8 the Onchange event of the TTabControl in not automatically called when you change the Tab Page programatically.
antekgla
on 13 Jan 2018
Related issues
hekm77
路
13Comments
leonsoft-kras
路
9Comments
Dustie
路
13Comments
MeganerdNL
路
8Comments
Pusha1d
路
7Comments
Most helpful comment
@PeterDaveHello Ok, thanks for the access.
I push this last commit directly to the master branch because I have already done it in my Github Desktop and frankly I dont know how to undo it. Only have pending the push.
In the future I will try to make the push to another branch ( I have to create it first?)
Regarding to the subject of this Issue I want to thank to the nice people of Lazarus forum specially to Getmem what nicely give me the answer to this issue, remarking what the problem is what in Lazarus 1.8 the Onchange event of the TTabControl in not automatically called when you change the Tab Page programatically.