Todo-tree: "magenta" not working as background for customHighlight

Created on 30 Jun 2019  路  6Comments  路  Source: Gruntfuggly/todo-tree

version: 0.0.136 (but already noticed this a couple of months ago)

For some reason I can't get background: "magenta" to work.
iconColour: "magenta" works ok for the tree-view icons.

All other colours work fine for both iconColour and background.

Can someone reproduce this behaviour?

"todo-tree.customHighlight": {
    "backlog1>": {
      "iconColour": "magenta",
      "background": "magenta"
    }
bug fixed

All 6 comments

That's weird - but I can reproduce it.

I had a flawed isHex function - basically it stripped non A-F characters out of the string and checked the length. Magenta -> 'aea' which looks like valid hex.

Should work properly now.

Could it be, this bug is reappearing in 0.0.141 ?
setting iconColour to 'magenta' results to white icons in the tree. 'red' for instance, does work.
image

It's because the icons were updated to match the new vscode style. Looks like the magenta ones were given the wrong colour.

Why is it always the magenta one?! :grin:

According to aviation psychologists, magenta is very well suited for drawing human attention in the cockpit...I hope they double checked 馃槓

New version with the magenta icon reinstated.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

the-vampiire picture the-vampiire  路  6Comments

JonathanTroyer picture JonathanTroyer  路  5Comments

luqiudi picture luqiudi  路  9Comments

Therzok picture Therzok  路  5Comments

WORMSS picture WORMSS  路  6Comments