Thegreatsuspender: Dark mode should also change colour of options menu

[deanoemcke]

As suggested by @JonnyRedHed in: https://github.com/deanoemcke/thegreatsuspender/issues/701#issuecomment-415625882

Can the settings page also go dark when dark mode is set. Seems only logical.

Also, once dark mode is turned on could you also make the icon drop down menu dark please.

Am using with Opera (stable-latest) with its dark mode UI turned on.

[JonnyRedHed]

While we are here talking about the icon drop down menu. This screen grab below is from Opera (latest-stable) and your see the menu looks a little big with rather a lot of white space. Apart from benefiting from being dark, when dark mode is on (in my opinion), the menu could do with a little work. See that top text line appears to break onto another line with the 'Not Now' text.

Windows 7 x64, is running at 125dpi. But Opera is at 100%.

[deanoemcke]

And while we're talking about text wrapping on the popup menu, here's the russian version (on OSX)

[liamjohnston]

Not so bad 😊 could have a bigger line height I guess but probably not
worth the trouble.

On Wed, Oct 10, 2018, 5:45 PM Dean Oemcke [e-mail] wrote:

And while we're talking about text wrapping on the popup menu, here's the
russian version (on OSX)

[image: image]
https://user-images.githubusercontent.com/1051763/46713654-ca054780-cc25-11e8-853e-72455e5ec829.png

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/deanoemcke/thegreatsuspender/issues/727#issuecomment-428436325,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABFQeWd4M6bj5OfJVRkK3sNFt2THiTElks5ujXtvgaJpZM4WKtjg
.

[JonnyRedHed]

Go on, make the icon drop down menu dark for this upcoming release please. Using Opera with its dark mode on would be a lot easier on the eyes 3am when the bright drop down menu is clicked. :)

[deanoemcke]

Popup has been themed for night mode now (#790).
Also see this subsequent commit (https://github.com/deanoemcke/thegreatsuspender/commit/dd391fecb225bd554e20193ae5a8b8621e675971)
Will leave this issue open for the other screens (ie. options)

[JonnyRedHed]

Thanks. So this will be out with 7.1 soon.

[JonnyRedHed]

Any update on this and the next main release.

[deanoemcke]

I've been swamped with moving to a new country. Giving it another regression test over the next week. Fingers crossed.

[JonnyRedHed]

Any update.

[deanoemcke]

Best to follow the milestone: https://github.com/deanoemcke/thegreatsuspender/milestone/1
I'll post any updates there. There's currently 3 open issues.

[JonnyRedHed]

The new dark mode is looking good. Thanks.