Thanos: Consider renaming Store Gateway.

[bwplotka]

It keeps coming a lot recently:

There is huge confusion between: store vs store gateway vs storeAPI We need to do something with it.

• storeAPI: a gRPC API which serves as an interface for reading stream of chunked series
• store gateway: https://thanos.io/components/store.md/ This is a service, a StoreAPI implementation that allows streaming series from object storages.
• store It is used as API and as gateway, depending on context :man_facepalming:

Proposals/ideas
Rename store Gateway to:

• bucketGateway
  
  
  
  • We might even be able to hook it to thanos bucket serve as we have `thanos bucket already which allows different things.
  
  
• bucketBrowser
• blockReader

[kerneljack]

Since the store gateway allows us to interact with remote cloud storage and/or blocks, how about storageGateway/blockStoreGateway/cloudStorageGateway? I think bucketGateway is a strange name.

[OGKevin]

bucketGateway could be an interface and could have storageGateway/blockStoreGateway/cloudStorageGateway as implementations.

TBH It is not confusing for me once I understood how Thanos works. With this being said, could this confusion not be solved with documentation rather than a refactor? And then use StoreAPI and StoreGateway and drop simple Store.

[squat]

Although the store gateway allows querying uploaded TSDB blocks, I think that names like blockGateway are a bit confusing because block can be conflated with block storage and because S3 and the like provide object storage as opposed to block storage.

I am a fan of storageGateway (:

[brancz]

BucketStore?

[FUSAKLA]

I actually do like BucketStore but it's not really the store :/

[jojohappy]

What about BucketGateway?

[wbh1]

+1 for storageGateway or even the more verbose objectStorageGateway.

Calling it a BucketGateway, in my opinion, makes it seem as if it is a gateway to a single bucket.

[bwplotka]

Something that might affect is that we might want to split at some point Store for fetching chunks and index lookup to separate components. We might want to be prepare for this with naming. bucketChunkGateway bucketIndexer

I would postpone the discussion and voting to that moment (:

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stale[bot]]

This issue/PR has been automatically marked as stale because it has not had recent activity. Please comment on status otherwise the issue will be closed in a week. Thank you for your contributions.

[bwplotka]

Looks like there is no much interest. Let's close it.

On Thu, 27 Feb 2020 at 11:14, stale[bot] [e-mail] wrote:

This issue/PR has been automatically marked as stale because it has not
had recent activity. Please comment on status otherwise the issue will be
closed in a week. Thank you for your contributions.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/thanos-io/thanos/issues/1646?email_source=notifications&email_token=ABVA3O6K7K5DUYB2EHKP5QDRE6OCXA5CNFSM4JAPAZJKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEND65VI#issuecomment-591916757,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABVA3O7COHDGHZP4M4T6RL3RE6OCXANCNFSM4JAPAZJA
.

[stale[bot]]

This issue/PR has been automatically marked as stale because it has not had recent activity. Please comment on status otherwise the issue will be closed in a week. Thank you for your contributions.

[bwplotka]

Something is broken with stale bot.