Thanos: Build is broken, cannot find package "github.com/Azure/azure-storage-blob-go/2018-03-28/azblob"

[paulcdejean]

admin@ip-10-2-60-103:~$ sudo docker run -it golang:1.10-stretch
root@522ff392f66c:/go# go get -d github.com/improbable-eng/thanos/...
package github.com/improbable-eng/thanos/cmd/thanos
        imports github.com/Azure/azure-storage-blob-go/2018-03-28/azblob: cannot find package "github.com/Azure/azure-storage-blob-go/2018-03-28/azblob" in any of:
        /usr/local/go/src/github.com/Azure/azure-storage-blob-go/2018-03-28/azblob (from $GOROOT)
        /go/src/github.com/Azure/azure-storage-blob-go/2018-03-28/azblob (from $GOPATH)
root@522ff392f66c:/go# exit
exit
admin@ip-10-2-60-103:~$ sudo docker run -it golang:1.11-stretch
Unable to find image 'golang:1.11-stretch' locally
1.11-stretch: Pulling from library/golang
bc9ab73e5b14: Already exists
193a6306c92a: Already exists
e5c3f8c317dc: Already exists
a587a86c9dcb: Already exists
1bc310ac474b: Already exists
87ab348d90cc: Pull complete
786bc4873ebc: Pull complete
Digest: sha256:feefda684b73cd8ef7548589c61270fd4b44156b8584b4aa483bcd7d40482524
Status: Downloaded newer image for golang:1.11-stretch
root@7ac4962cb182:/go# go get -d github.com/improbable-eng/thanos/...
package github.com/improbable-eng/thanos/cmd/thanos
        imports github.com/Azure/azure-storage-blob-go/2018-03-28/azblob: cannot find package "github.com/Azure/azure-storage-blob-go/2018-03-28/azblob" in any of:
        /usr/local/go/src/github.com/Azure/azure-storage-blob-go/2018-03-28/azblob (from $GOROOT)
        /go/src/github.com/Azure/azure-storage-blob-go/2018-03-28/azblob (from $GOPATH)
root@7ac4962cb182:/go#

[paulcdejean]

https://github.com/Azure/azure-storage-blob-go/issues/86

[bwplotka]

Looks like the build works, but we no longer can do go get -d github.com/improbable-eng/thanos/... for Thanos project as we documented in Getting Started guide.

@vglafirov any ideas?
I am pretty sure go clone && make deps will work for @paulcdejean here, so we might just want to update Getting Started as a first thing, as we cannot do much more - upstream azure sdk just removed the used folder from master.

Otherwise we could look on go 1.11 support (https://github.com/improbable-eng/thanos/pull/602) which could improve whole process.

[bwplotka]

Alternatively we can import main dir directly and pin to some version, what do you think @vglafirov ?

[vglafirov]

I am on it