Thanos: Remove gossip from Dashboards and benchmark tool

[povilasv]

We should remove gossip info from the example Grafana dashboards and the benchmark/cmd/thanosbench/*.

[AlexisSellier]

I would like to work on this.

[povilasv]

@AlexisSellier awesome, let me know if you need any help

[yeya24]

@AlexisSellier Are you still working on this? If not, I'd like to take this.

[AlexisSellier]

Go ahead, I still have not internet yet at home due to relocation so I cannot work on it atm

[yeya24]

Hi @povilasv . Currently I am working on this, but I am quite confused about this function https://github.com/improbable-eng/thanos/blob/2dadd9caa73343d043bc43062fa8e6a32bac1d9e/benchmark/cmd/thanosbench/resources.go#L497.

What is this image? Is it thanos-querier? Do I have to change this?

Containers: []v1.Container{{
                    Name: "querier",
                    //TODO(domgreen): move this to the same repository as Thanos
                    Image: "eu.gcr.io/io-crafty-shelter/thanos-querier:latest",
                    Args: []string{
                        "--host=" + endpoint,
                        "--queries=" + queries,
                        "--range-offset-start=" + opts.queryRangeOffsetStart.String(),
                        "--range-offset-end=" + opts.queryRangeOffsetEnd.String(),
                        "--query-time=" + opts.queryTime.String(),
                        "--server=true",
                    },
                }},

[povilasv]

@domgreen might know more :)

[bwplotka]

Sorry @yeya24 for delay. This is some leaked image, you don't need to worry about this now.

Let's focus on dashboards only now (:

[yeya24]

Sorry for the delay @bwplotka . But I am considering is it necessary to maintain the dashboard in this repo? IMO it is better to use https://github.com/metalmatze/kube-thanos. WDYT @bwplotka , do we need to add a doc about that?

[bwplotka]

Yes, I think the link or even repo in Thanos-io org would be nice indeed

[yeya24]

Yes, I think the link or even repo in Thanos-io org would be nice indeed

Agree. /cc @metalmatze