Thanos: TODO: Rename index cache YAML fields: type => backend, config => backend_config

Created on 7 May 2020  路  4Comments  路  Source: thanos-io/thanos

https://github.com/thanos-io/thanos/pull/2532 has introduced new cache config for caching bucket. In this PR, we use backend and backend_config YAML fields for selecting type of cache (memcached only for now), and its configuration.

This is different than what is used by index cache, where we use type and config. We would like to rename these to backend and backend_config as well at some point.

picture pstibrany

Most helpful comment

Closing as a result of the discussion on Slack https://cloud-native.slack.com/archives/CL25937SP/p1589816009201600.

Let us know if this is still desired.

picture kakkoyun on 19 May 2020
👍2

All 4 comments

This is to be done after #2532 gets merged, right?
I would like to fix this if it's ok.

ranjithkumar007 picture ranjithkumar007 on 7 May 2020

This is to be done after #2532 gets merged, right?

Yes.

I would like to fix this if it's ok.

That would be great! Thanks.

pstibrany picture pstibrany on 7 May 2020
🚀1

We can close this now?

ranjithkumar007 picture ranjithkumar007 on 18 May 2020

Closing as a result of the discussion on Slack https://cloud-native.slack.com/archives/CL25937SP/p1589816009201600.

Let us know if this is still desired.

kakkoyun picture kakkoyun on 19 May 2020
👍2
Was this page helpful?
0 / 5 - 0 ratings

Related issues

gburek-fastly picture gburek-fastly  路  4Comments
barryib picture barryib  路  4Comments
sepich picture sepich  路  4Comments
bwplotka picture bwplotka  路  4Comments
hedeesaa picture hedeesaa  路  3Comments