Thanos: Describe verify/repair commands

[bwplotka]

• How to use it
• How to extend/modify it
• What is that for

[domgreen]

@Bplotka can I close down this issue?

[bwplotka]

Not really. We need to also describe all of the verify/repair "issues" we have: https://github.com/improbable-eng/thanos/blob/master/cmd/thanos/bucket.go#L25 but you can leave that to me. You did the major part though, thanks!

[jabbrwcky]

Also the documentation should specify prerequisites for running verifier.

I stumbled across the log message GLOBAL COMPACTOR SHOULD __NOT__ BE RUNNING ON THE SAME BUCKET issued by the verifier, and was wondering if my setup is wrong.

I dug a little bit and found that this message is a blanket message output here: https://github.com/thanos-io/thanos/blob/7e11afe64af0c096743a3de8a594616abf52be45/pkg/verifier/verify.go#L49

There is no documentation or any easily identifiable issue that explains the why of this message.

I assume that the verifier with repair enabled should not run concurrently with the compactor, but this is just a guess.

I think that running the verifier read-only with a running compactor should not have negative impact, in which case it might be enough to show this message only if repairs are enabled.

In any case the documentation should refelect when to stop the compactor before running verify.

[stale[bot]]

This issue/PR has been automatically marked as stale because it has not had recent activity. Please comment on status otherwise the issue will be closed in a week. Thank you for your contributions.