Test-infra: boskos-cleaner doesn't exist

[fejta]

/assign @fejta @chases2
/kind oncall-hotlist

bash-3.2$ kubectl --context=prow get deployments
NAME                READY   UP-TO-DATE   AVAILABLE   AGE
crier               1/1     1            1           252d
deck                3/3     3            3           406d
ghproxy             1/1     1            1           484d
hook                4/4     4            4           2y292d
horologium          1/1     1            1           2y207d
needs-rebase        1/1     1            1           587d
plank               1/1     1            1           2y1d
prow-build          1/1     1            1           288d
prow-pipeline       1/1     1            1           127d
pushgateway         1/1     1            1           2y0d
pushgateway-proxy   1/1     1            1           2y0d
sinker              1/1     1            1           2y4d
statusreconciler    1/1     1            1           148d
tide                1/1     1            1           2y27d
tot                 1/1     1            1           2y255d
bash-3.2$ kubectl --context=prow-builds get deployments
NAME         READY   UP-TO-DATE   AVAILABLE   AGE
greenhouse   1/1     1            1           559d
bash-3.2$ kubectl --context=prow-builds get deployments -n test-pods
NAME                    READY   UP-TO-DATE   AVAILABLE   AGE
boskos                  1/1     1            1           10d
boskos-janitor          3/3     3            3           671d
boskos-janitor-aws      4/4     4            4           176d
boskos-janitor-nongke   4/4     4            4           514d
boskos-metrics          1/1     1            1           671d
boskos-reaper           1/1     1            1           671d
curl                    1/1     1            1           215d
grandmatriarch          1/1     1            1           370d
bash-3.2$ kubectl --context=prow-builds get deployments -n boskos   
No resources found.
bash-3.2$ kubectl --context=prow get deployments -n boskos
No resources found.
bash-3.2$

Let's figure out if we want it or not

In addition, it targets a bad namespace:
https://github.com/kubernetes/test-infra/blob/5458503e8b07feacd8c3d38ab77e959326bda435/prow/cluster/boskos-cleaner.yaml#L18

[fejta]

/assign @sebastienvas @krzyzacy

[krzyzacy]

(isn't the cleaner only runs on istio prow?)

[fejta]

I have no idea. There are files for it in here, and a Makefile rule to deploy it

[fejta]

What does it do? Why does istio need it? Why doesn't k8s?

[krzyzacy]

we don't use dynamic resources, istio does. https://github.com/istio/test-infra/blob/master/boskos/resources.yaml#L41-L45

[krzyzacy]

@sebastienvas we can delete the deployment file here, right?

[sebastienvas]

yes you can delete it for this deployment. I just made one as an example.

[stevekuznetsov]

IMO we should split the example YAMLs like starter.yaml with actual prow.k8s.io deployment YAML. Seems like we could keep examples in prow/cluster but move specifics for deploying and configuring prow.k8s.io to config/ etc

[fejta]

Hmm, decent idea -- moving the cluster configs into the config dir

I think the examples should live near the code, so perhaps the cleanup example should live in the cleanup

[fejta]

I migrated it because I wasn't aware we didn't use it