Test-infra: The ClientError type is not unmarshalled correctly.

[cjwagner]

The ClientError type added in #5059 is not unmarshalled correctly for label removal errors. Here are the logs:

jsonPayload: {
  author:  "dims"   
  error:  "error removing label from kubernetes/kubernetes#55657: json: Unmarshal(non-pointer github.ClientError)"   
  event-GUID:  "a17802e0-c946-11e7-8693-daf214139907"   
  event-type:  "pull_request"   
  level:  "error"   
  msg:  "Error handling PullRequestEvent."   
  org:  "kubernetes"   
  plugin:  "docs-no-retest"   
  pr:  55657   
  repo:  "kubernetes"   
  url:  "https://github.com/kubernetes/kubernetes/pull/55657"   
}

jsonPayload: {
  author:  "nikhita"   
  error:  "encountered 1 errors setting labels: [json: Unmarshal(non-pointer github.ClientError)]"   
  event-GUID:  "6a61f320-c945-11e7-921f-4d64733317cf"   
  event-type:  "issue_comment"   
  level:  "error"   
  msg:  "Error handling IssueCommentEvent."   
  org:  "kubernetes"   
  plugin:  "release-note"   
  pr:  55622   
  repo:  "kubernetes"   
  url:  "https://github.com/kubernetes/kubernetes/pull/55622#issuecomment-344269947"   
 }

/cc @BenTheElder

[cjwagner]

I think this line just needs to have an &.
https://github.com/kubernetes/test-infra/blob/1ff53bd440641480c383c8c8edac0bfe022db6db/prow/github/client.go#L154

[BenTheElder]

That's in https://github.com/kubernetes/test-infra/pull/5512 as of 2 minutes before this issue :joy:

[kargakis]

fixed