Test-infra: Unit test prow flags

Created on 9 Apr 2019  路  10Comments  路  Source: kubernetes/test-infra

We should validate that flag values work as expected.

See https://github.com/kubernetes/test-infra/blob/86a523febb3c6af836859dda5624dcbea7204f7a/prow/cmd/build/main_test.go#L25-L66 for an example of what this will look like

Also likely will require passing in a flagset and args to the gather method: https://github.com/kubernetes/test-infra/blob/86a523febb3c6af836859dda5624dcbea7204f7a/prow/cmd/build/main.go#L72

P0

  • [x] build
  • [ ] crier
  • [ ] deck
  • [ ] hook
  • [x] horologium
  • [ ] plank
  • [x] sinker
  • [ ] tide

P1

  • [ ] checkconfig
  • [ ] clonerefs
  • [ ] entrypoint
  • [ ] gcsupload
  • [ ] initupload
  • [ ] sidecar

P2

  • [ ] artifact-uploader
  • [ ] branch-protector
  • [ ] config-bootstrapper
  • [ ] gerrit
  • [ ] jenkins-operator
  • [ ] status-reconciler
  • [ ] sub

P3

  • [ ] mkbuild-cluster
  • [ ] mkpj
  • [ ] mkpod
  • [ ] peribolos
  • [ ] phony
  • [ ] tackle
  • [ ] tot

/area prow

areprow good first issue help wanted kinfeature lifecyclrotten sitesting

Most helpful comment

@fejta Can we update the checkboxes to clarify which components still need tests?

All 10 comments

/help
/good-first-issue

Good opportunity to learn about various pieces of the system!

@fejta:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/help
/good-first-issue

Good opportunity to learn about various pieces of the system!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fejta, would like to pick this.

@yashbhutwala @fejta "Crier" is the only P0 command that hasn't been addressed left, correct?

@fejta Can we update the checkboxes to clarify which components still need tests?

/sig testing

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

MrHohn picture MrHohn  路  4Comments

BenTheElder picture BenTheElder  路  4Comments

fejta picture fejta  路  4Comments

stevekuznetsov picture stevekuznetsov  路  3Comments

sjenning picture sjenning  路  4Comments