Test-infra: verify-owners: ensure every user is an org collaborator
https://github.com/kubernetes/kubernetes/issues/50048 and https://github.com/kubernetes/contrib/issues/2713 are issues about ensuring that every user in an OWNERS or OWNERS_ALIASES file is an org member or outside collaborator.
Rather than doing a manual scan occasionally, we could add this check to the verify-owners plugin and automate it.
If this sounds good, I can work on it.
/cc @cblecker @spiffxp @dims @cjwagner @BenTheElder
/sig contributor-experience
/area prow
/kind feature
nikhita
All 17 comments
I think it's a good idea! Thanks.
ping035627
on 26 Dec 2018
This would potentially open the door to abuse so we'd have to cap the number of people we check when someone commits an OWNERS file, but otherwise sounds reasonable.
stevekuznetsov
on 26 Dec 2018
Capping the number of people we check wouldn't really be a barrier to abuse. It is still possible to just repeatedly push new commits to keep triggering validation. This is true for most all of our automation unfortunately.
A cap would still be good to avoid using all our tokens if/when big OWNERS file refactors happen, though.
cjwagner
on 26 Dec 2018
/assign
nikhita
on 28 Dec 2018
I couldn't get this working on a private repo, but wanted to test here just to make sure I'm not imagining this category for /pony...
/pony lgtm
nikhita
on 14 Jan 2019
@nikhita:
In response to this:
I couldn't get this working on a private repo, but wanted to test here just to make sure I'm not imagining this category for
/pony.../pony lgtm
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
k8s-ci-robot
on 14 Jan 2019
/pony approve
spiffxp
on 14 Jan 2019
@spiffxp: Couldn't find a pony matching that query.
In response to this:
/pony approve
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
k8s-ci-robot
on 14 Jan 2019
/pony sad
spiffxp
on 14 Jan 2019
@spiffxp:
In response to this:
/pony sad
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
k8s-ci-robot
on 14 Jan 2019
Just for the record - this was fixed in https://github.com/kubernetes/test-infra/pull/10741. :)
nikhita
on 14 Jan 2019
@spiffxp If you can explain the difference between an lgtm pony and an approval pony, I will make /pony approve work. ;)
Katharine
on 14 Jan 2019
Here too: https://github.com/kubernetes/test-infra/issues/8838#issuecomment-436075246 @tallclair
matthyx
on 15 Mar 2019
@nikhita are you working on that issue?
matthyx
on 15 Mar 2019
nikhita
on 21 Apr 2019
/reopen
This was reverted in https://github.com/kubernetes/test-infra/pull/12402.
Created https://github.com/kubernetes/test-infra/pull/12460 to fix it and add the feature again.
nikhita
on 2 May 2019
@nikhita: Reopened this issue.
In response to this:
/reopen
This was reverted in https://github.com/kubernetes/test-infra/pull/12402.
Created https://github.com/kubernetes/test-infra/pull/12460 to fix it and add the feature again.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
k8s-ci-robot
on 2 May 2019
Related issues
benmoss
路
3Comments
stevekuznetsov
路
3Comments
lavalamp
路
3Comments
BenTheElder
路
4Comments
cjwagner
路
3Comments
Most helpful comment
@spiffxp If you can explain the difference between an lgtm pony and an approval pony, I will make
/pony approvework. ;)