Test-infra: Replace gubernator links with spyglass links

Created on 6 Dec 2018  Â·  9Comments  Â·  Source: kubernetes/test-infra

We want to deprecate gubernator (except for its PR dashboard). Before we can do that, we need to:

  • [x] Merge the PR history view (#10169)
  • [x] Show pod logs as necessary even when given GCS URLs
  • [x] Add testgrid integration (but do we really want to couple prow and testgrid? gubernator does this by reading the testgrid config proto...)
  • [x] Add links to view artifacts
  • [x] Improve the failed test display (at least make the failure text more legible)
  • [ ] Node log viewing?
  • [x] For transitional purposes, add a link to gubernator

Anything I missed? We can already:

  • [x] Show the build log
  • [x] Show test results
  • [x] Show build metadata
  • [x] Show job histories

Some of these things are probably uncommon (node logs?) and at least initially are sufficiently served by the link to gubernator.

aregubernator areprodeck

Most helpful comment

I did some work on the UI to prettify it in #10929 / #10932, which hopefully at least mostly resolves the broadest design complaints (@spiffxp):

image

All 9 comments

/area prow/deck
/area gubernator
/assign

Add testgrid integration (but do we really want to couple prow and testgrid? gubernator does this by reading the testgrid config proto...)

The current coupling may be ugly, there's probably a better way to do it that will require some rearchitecting, but the mapping from job <-> history of job runs (in testgrid form) is very useful. I can quickly jump from how is _this_ run doing, to how have _all_ runs been doing

Improve the failed test display (at least make the failure text more legible)

Agree. I'm not sure how many people use the "click to see stdout/stderr" link, but if nothing else it's additional info captured in the junit file that could be displayed nicely

eg: https://gubernator.k8s.io/build/kubernetes-jenkins/logs/ci-kubernetes-node-kubelet/17584#k8sio-summary-api-nodeconformance-when-querying-statssummary-should-report-resource-usage-through-the-stats-api

From my design nerd perspective, it doesn't appear dense enough. Don't get me wrong, whitespace is good. This doesn't feel like it's been put through a pass with that kind of eye though.

Text is small. I see N different kinds of font styles. It would be nice use a grid or something for consistent alignment
screen shot 2018-12-07 at 11 08 00 am

Yes... spyglass has basically no CSS yet because that comes after the
functionality works fully!
give me working podlogs cough @ibzib cough and I might take a look slash
poke @Katharine

On Fri, Dec 7, 2018 at 11:09 AM Aaron Crickenberger <
[email protected]> wrote:

From my design nerd perspective, it doesn't appear dense enough. Don't get
me wrong, whitespace is good. This doesn't feel like it's been put through
a pass with that kind of eye though.

Text is small. I see N different kinds of font styles. It would be nice
use a grid or something for consistent alignment
[image: screen shot 2018-12-07 at 11 08 00 am]
https://user-images.githubusercontent.com/49258/49667589-683c4080-fa10-11e8-8184-b4c89cf37fdc.png

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes/test-infra/issues/10375#issuecomment-445334348,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA4BqwLZBfVzt_J29Jm9SoBtFm3o9EU8ks5u2rzxgaJpZM4ZHXIl
.

I'm pretty sure none of this has been put through any sort of pass beyond "yes, this is technically capable of rendering information from artifacts". There has been slightly more effort on the build logs.

re metadata viewer, I put in #10406. I wouldn't say it looks _good_ now, but at least it's not spread out into different tables and cluttered with empty fields anymore.

I did some work on the UI to prettify it in #10929 / #10932, which hopefully at least mostly resolves the broadest design complaints (@spiffxp):

image

Will also want to update links in go.k8s.io/triage (test-infra/triage)

This happened.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

stevekuznetsov picture stevekuznetsov  Â·  3Comments

MrHohn picture MrHohn  Â·  4Comments

xiangpengzhao picture xiangpengzhao  Â·  3Comments

BenTheElder picture BenTheElder  Â·  4Comments

BenTheElder picture BenTheElder  Â·  3Comments