Test-infra: k8s-ci-robot don't update sig/area/kind on pr changes

[yagonobre]

What happened?

I remove some code from my pr, and the k8s-ci-robot don't clean up the labels related to sig, area and kind.

I can send a pr to fix that.

/kind bug

[BenTheElder]

/area prow
cc @cjwagner

[yagonobre]

I'll close this issue, because make k8s-ci-robot remove this labels will remove manually added labels too.

[nikhita]

I'll close this issue, because make k8s-ci-robot remove this labels will remove manually added labels too.

IMHO it would still be useful to remove the labels. Most manually added labels are kind/* labels and the bot does not add this label automatically. The bot only adds the area/* and sig/* labels automatically, which are rarely changed manually. In such cases, I think manually changing them again should be fine. Wdyt?

[yagonobre]

@nikhita make senses! I'll work on it tomorrow.

[cjwagner]

Disregard my deleted comment, I was confused.

I'm still not sure this is the right decision though. This will make using the /area and /sig commands on PRs very annoying. Repeating the commands after every PR update will be irritating and produce a lot of notification/email spam. I think there will also be an issue with not noticing that manually added labels have been unintentionally removed.

It makes more sense to me to not remove these labels automatically. If a PR has a label that it shouldn't, the label can be removed with /remove-area or /remove-sig and it seems easier to notice an incorrectly applied label than a missing label.

If this feature only makes sense for some labels we could add configuration to indicate which labels can be automatically removed?

[nikhita]

If a PR has a label that it shouldn't, the label can be removed with /remove-area or /remove-sig and it seems easier to notice an incorrectly applied label than a missing label.

:+1:

If this feature only makes sense for some labels we could add configuration to indicate which labels can be automatically removed?

I can't think of any such labels. :thinking:

[nikhita]

@yagonobre Do you think we need to add such configuration for some labels? If not, please feel free to close the issue. Sorry for the confusion. :)

[yagonobre]

I no have enough context to know if we have any labels that must be automatically removed.

[cjwagner]

Closing for now. Lets reopen if/when we find a use case for this.