Test-infra: Prow config is mixing camelCase, _underscores _, and -hyphens-
- camelCase, eg.
missingLabelsin the tide config - underscores, mostly used eg.
push_gateway - hyphens, eg.
branch-protection
We should probably converge to a single format and stick with it.
@fejta @stevekuznetsov @cjwagner @BenTheElder @krzyzacy
/area prow
kargakis
All 17 comments
/shrug
kargakis
on 9 May 2018
+1 to snake_case IMO
stevekuznetsov
on 9 May 2018
/kind bug
/area bikeshed
BenTheElder
on 9 May 2018
we should also document whatever we move to somewhere or have a config linter to prevent regressions.
BenTheElder
on 9 May 2018
I vote hyphens, but I don't care much as long as we are consistent.
cjwagner
on 9 May 2018
pronounSubject_I verbPredicate_Think pronounSubject_We verbAuxilliary_Should verbPredicate_Use adjective_Hungarian nounDirect_Notation
fejta
on 9 May 2018
We should make label_sync randomly assign a new color to the area/bikeshed label whenever the tool runs
fejta
on 9 May 2018
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale
fejta-bot
on 8 Aug 2018
/remove-lifecycle stale
If we want to look like k8s we should go with camelCase. Generically, can we write a serializer that loads either from field_name if present or fieldName if not? then we can do this migration slowly.
stevekuznetsov
on 31 Aug 2018
We can add a new type embedding the real type temporarily that exposes the alternate field and then fixup that type into the real type.
+1 for going k8s style with camelCase for consistency.
BenTheElder
on 31 Aug 2018
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale
fejta-bot
on 29 Nov 2018
Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
fejta-bot
on 29 Dec 2018
/remove-lifecycle rotten
idealhack
on 31 Dec 2018
/lifecycle frozen
/remove-kind bug
/kind cleanup
/milestone 2019-goals
Consistency helps discoverability and adoption
spiffxp
on 3 Jan 2019
/remove-lifecycle frozen
all the inconsistencies remain
spiffxp
on 11 Sep 2020
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale
fejta-bot
on 10 Dec 2020
Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
fejta-bot
on 9 Jan 2021
Related issues
cblecker
·
4Comments
chaosaffe
·
3Comments
zacharysarah
·
3Comments
cjwagner
·
3Comments
Aisuko
·
3Comments
Most helpful comment
We should make label_sync randomly assign a new color to the area/bikeshed label whenever the tool runs