Team-comtress-2: Left Handed/Flipped Viewmodel fixes

[renimg]

Description

I wasn't sure whether to put this under a Feature Request or a Bug Fix Request, but as a left-handed person the left handed view models have always bugged me due to straight up being inferior to the right-handed view models, things like jigglebones completely breaking weapons or inverting them, to minor things like text being mirrored, it doesn't break the game, it would just be a super solid QoL change for us few who play the game left handed

The weapons affected, including what's broken with them

Scout

• Soda Popper - Mirrored Text
• Mad Milk - Partially Inverted Model
• Bonk/Crit-a-Cola - Mirrored Text
• Flying guillotine - Mirrored Text
• atomizer - Mirrored Text
• Wrap Assassin - Partially Inverted Model
• Sandman - Mirrored Text, Partially Inverted Model
• Holy Mackerel - Partially Inverted Model
• unarmed combat - Partially Inverted Model

Soldier

• Black Box - Partially Inverted Model
• Disciplinary Action - Partially Inverted Model

Demoman

• Bottle - Mirrored Text
• Scottish Handshake - Mirrored Text

Pyro

• Postal Pummeler - Mirrored Text

Heavy

• Second Banana - Partially Inverted Model
• Dalokoh's Bar - Mirrored Text

Medic

• Overdose - Mirrored Text
• Solem Vow - Mirrored Text
• Vita-Saw - Partially Inverted Model

Sniper

• Self Aware Beauty Mark - Mirrored Text

Spy

• Disguise Kit - Mirrored Text
• Electro Sapper - Mirrored Text
• Dead Ringer - Cloak timer non-existant, have to stare down at the ground to make it appear
• cloak and dagger - Cloak timer non-existant, have to stare down at the ground to make it appear
• Invis Watch - Cloak timer non-existant, have to stare down at the ground to make it appear
• Enthusiast's Timepiece - Cloak timer non-existant, have to stare down at the ground to make it appear
• Quackenbirdt - Cloak timer non-existant, have to stare down at the ground to make it appear

Multi-Class

• Crossing Guard - Mirrored Text
• Ham Shank - Partially Inverted Model
• Bat Outta Hell - Partially Inverted Model
• Necro Smasher - Partially Inverted Model
• All botkillers - Heads mirrored, Partially Inverted Models

Checklist

• [x] None of the open or closed issues document this idea.
• [ ] This is a new idea, not a bug.
• [x] This idea does not seriously affect game balance.
• [x] This idea is for the code of the game, not for textures, sounds, or other resources.
• [x] This is not an idea for new game content (e.g. new weapons, maps, sounds).
• [x] This is obviously an improvement, not something that people commonly disagree on.

Screenshots

Here is a Imgur album of all of them, i might've missed a few
https://imgur.com/a/0jAvZxB

[renimg]

ah I meant to label this for TF2, apologies.

[Malfunktion-issues]

I was actually just about to make a report about this, the Bat Outta Hell's other styles break worse in left handed mode. I've tested it with all classes that can equip it, and they all break in the same way.

(The jaw got broken after about three or four critical swings in a row and persists after respawning.)

[MikhailaTF]

Incidentally, when you fire the Machina or the Hitman's Heatmaker with flipped viewmodels enabled, the beam originates from the wrong side of the screen. Figured this issue fits here as well.

[renimg]

Went through the game and found a few more broken weapons that weren't listed

• Ullapool caber - Mirrored Text
• Flying Guillotine - Mirrored Text
• Red-Tape Recorder - Mirrored Text
• Festive Bonk - Mirrored Text
• Festive Holy Mackerel - Broken Jigglebones
• Festive Jarate - Mirrored Text
• Festive Huntsman - Broken Jigglebones, Mirrored Text
• Festive Axtinguisher - Broken Jigglebones
• Festive Grenade Launcher - Broken Jigglebones
• Festive Ubersaw - Broken Jigglebones
• Conscientious Objector - Decal mirrored
• Festivizers - Mirrored text on batteries

https://imgur.com/a/wVlg5uc Here is more images

[treacherousfiend]

Many of the broken jigglebones also happen on regular viewmodels,
Flipped text is kind of not a thing that can be fixed without making separate textures for left handed weapons, which seems unnecessary. I could look into flipped viewmodel just literally flipping the animations (rather than mirroring the rendering layer for viewmodels, which is what it seems like they did), but this might cause other issues, and would also likely make some text not even visible, due to it being in the wrong spot.

Edit: Machina & Hitman's Heatmaker laser is probably easily fixable, i'll look into that
Edit 2: Forgot to mention inverted models for botkillers, also likely a consequence of mirroring the rendering layer, should in theory be fixed if I flip the animations

[renimg]

Many of the broken jigglebones also happen on regular viewmodels,

I wrote this when tired, broken jigglebones refers to inverted models, my mistake

[treacherousfiend]

No you were right on some of them, Holy Mackerel for example has broken jigglebones.
Also I took a quick look at the code and it looks like they literally just invert the model for the flipped viewmodels. They also revert that for stat clocks so that they're readable. its a whole weird thing.