Team-comtress-2: [MVM] Mphhh ubercharge canceling

[joshuadinada]

Description

If you use the "Become ubercharged" canteen, and when it's about to finish activate the "Mphhhh" effect from the phlogistinator, the ubercharge from the phlog will be cancelled

Checklist

• [x] None of the open or closed issues document this problem.
• [x] This is a bug, not a new idea.
• [x] This is objectively a bug, and not something that people commonly disagree on.
• [x] This bug is in the code of the game, not in the textures, sounds, or other resources.
• [x] This issue occurs on the latest vanilla TF2 update.
• [ ] This issue is listed on the Source 1 official bugtracker.
• [ ] This issue occurs with DirectX level 100.
• [x] This issue occurs on the latest Team Comtress release, or the master branch.
• [x] This issue occurs when using no custom content.
• [x] This issue occurs when using start_tf2.bat (or start_server.bat) with no custom launch options.
• [x] This issue occurs when using a listen server (using the map command ingame).
• [ ] This issue occurs when using a dedicated server.
• [ ] This bug is in the internal procedures or tooling (e.g. the build process).

Reproduction

1. Start a server with a MvM map.
2. Select pyro and equip the phlogistinator
3. Buy the ubercharge power-up
4. Start the wave and kill some robots to build up the mphhh meter
5. Once the mphhh meter is charged, activate the ubercharge.
6. Wait for about 3-4 seconds and then activate the mphhh effect.

Setup Details

• Server or client: Client.
• Operating system: Windows 10
• Team Comtress version: 0.0.17
• Custom content: None.
• Launch options: None.
• DirectX level: None.

[Yttrium-tYcLief]

This is sort of an unintentional design flaw due to how conditions work in TF2. I've discussed this on a similar issue somewhere, can't find it right now, but essentially conditions don't have their timers reset when being re-applied. You can't have multiple overlapping conditions; a real uber being applied to an mmph'ing pyro will overwrite their original mmph uber with the real one, and then the uber will run out when the uber would normally run out, which means you can simply flash a pyro to completely cancel out their uber invulnerability.

Fixing it would require a major revamp to the condition system. It could be done, but would take a lot of work and would likely break demos, so it's probably outside of project scope.

[joshuadinada]

This might also happend with normal ubercharge from a medigun. Might need to test it tough.

[sticks-stuff]

This does not happen with regular medigun ubercharge