Tdesktop: Case Invariant Emoji Suggestions

[TheYarin]

As a user that chats in telegram in a language other than English, it is quite frustrating to switch to English every time I want to see the emoji suggestions.
It would be lovely if these suggestions will appear even if I type :HEART: instead of :_heart: (without the underscore), so I could just hold the SHIFT key down while typing an emoji search while the input language remains .

Cheers!

[stek29]

So even GitHub doesn't do this 😅

[TheYarin]

@stek29 It seems GitHub gives suggestions even when I write :HEART:, it just doesn't automatically replace :HEART: with ❤️ . I can live with that 😅

[pentix]

@Dyedan Did you expect something like this?

[TheYarin]

Yes, exactly that!

[pentix]

@Dyedan I wrote a patch for this and just submitted it as pull request #4429. Let's just hope it gets accepted 😄

[TheYarin]

Thank you! I hope they'll merge it!

[MasterGroosha]

@Dyedan since your PR is merged, now we cannot easily type :D, :P and other short text emoji. Looks like a regression rather than a "feature".

[john-preston]

@MasterGroosha yeah, I see that effect as well :/ I guess I didn't think this through and perhaps it should be reverted. Not sure yet.

[pentix]

@john-preston @MasterGroosha I didn't see this either. What about increasing the number of letters needed for suggestion to two? I think nobody really relies on the only-one-char-suggestion since it's a purely speculative thing anyway. This would provide a fix for the cases mentioned above.

[john-preston]

@pentix I can make the string lowercase (case insensitive autocompletion) in case of two letters and case sensitive in case of one letter (for :o for example).

[pentix]

@john-preston This sounds like a good idea. :relaxed:

[TheYarin]

@MasterGroosha Sorry 😅
@pentix Excellent idea, I think this will work well!
@john-preston I think it would be better to use case insensitivity when there are atleast 2 letters instead of only when there are exactly 2 letters, don't you?

[timocov]

Another case where other emoji is selected is just type :-D and then press enter (with enabled Replace emoji in the settings).

For now workaround is type space after typing emoji and then press enter, but it is annoying.

[pentix]

@john-preston I saw your suggested changes in b6e7625, thanks a lot!

[stek29]

Regression (well, TAB/return still works but just typing does not)

[pentix]

@stek29 Are you referring to the fix that requires two letters? Or what happens exactly?

[stek29]

@pentix see 4b763a76df514c6f98bc588b66b8df070ec66d85

[Aokromes]

this issue is still valid on 1.9.8?

[pentix]

@Aokromes With above's changes all being merged in, I haven't had a similar issue for a while; Seems this can be closed.