Talk: If the Edit Timeframe Window is set to > 59 seconds, display time remaining in minutes instead of seconds

Created on 4 Oct 2017  路  7Comments  路  Source: coralproject/talk

Currently, the edit timeframe window is always displayed in seconds. We should be clever about this and display in minutes and seconds when it's more appropriate.

E.g. "300 seconds" should display as "5 minutes"

This would only be the case in displaying this on the Comment Stream to the commenter. We can keep the Configuration setting in seconds to be 100% precise.

good first issue hacktoberfest
Source
picture kgardnr

All 7 comments

I'd like to work on the issue.

Rishabh04-02 picture Rishabh04-02 on 4 Oct 2017

Hi @Rishabh04-02! That sounds great, welcome and thank you!

kgardnr picture kgardnr on 4 Oct 2017
👍1

I'm sorry to butt in, but I ended up writing a PR for it, see https://github.com/coralproject/talk/pull/1058

holmberd picture holmberd on 5 Oct 2017
😕1

@kgardnr Please review #1059

Rishabh04-02 picture Rishabh04-02 on 5 Oct 2017

Hi @Rishabh04-02 and @holmberd! Thank you both for your efforts! I'm going to have to go with Risha's PR, Dag, because he did claim the issue first. I do hope you both continue to contribute to Talk, we would love to have you both involved :)

kgardnr picture kgardnr on 5 Oct 2017
🎉1

Haha no worries. Surprisingly similar solution ;)

holmberd picture holmberd on 5 Oct 2017
❤1

Fixed in #1059

kgardnr picture kgardnr on 24 Oct 2017
Was this page helpful?
0 / 5 - 0 ratings

Related issues

martinmags picture martinmags  路  4Comments
aliblackwell picture aliblackwell  路  4Comments
mattlinares picture mattlinares  路  3Comments
cristiandean picture cristiandean  路  5Comments
SSO
deepaksisodiya picture deepaksisodiya  路  4Comments