Surge: Arrows Menus Linux

[tank-trax]

This is happening in Linux
OS: Debian 9 Stretch
Build:

I just noticed that the up and down arrows only work on the bottom level menu

For example, from the Categories Bass to Zoozither it is not possible to use arrows to navigate up or down, only the mouse works

However the sub-menus with the patches it is possible to use the arrows to navigate, and press enter to select the preset

For Categories that have sub-categories such as

Giana Brothers
Kuniklo
Nick Moritz

it is only the patches that the arrows can navigate, not the sub-categories

this possibly started happening around #1186

the same behavior happens on the FX menu and the Main menu

same behavior on VST3 and LV2

just noticed if the mouse is off the menu the arrows can work, however of moving back or up to the previous or upper level menu the arrows no longer respond and that item stays selected until the mouse over

for the arrows to work the menu has to be closed and reopened

[baconpaul]

Arrows you mean arrow keys?

[baconpaul]

Oh and if I had to guess I’d say the vstgui animation change may be a more likely culprit (that’s https://github.com/surge-synthesizer/surge/commit/69ea9cec44b997dd1d5713273ceea86882b940e7 and #1124 / #1125 ) but I haven’t looked closely. Backing up to before 69ea9cec, running a submodule update init recursive, and clean building would be the first thing I would try.

[tank-trax]

Yes the up, down, right, and left arrow keys. Navigation is limited. The arrows can only move up and down if the mouse of not focused on the menu. Cannot go from a sub-menu back to a higher level as that will freeze the selection there.

[tank-trax]

git reset 69ea9ce

git log
commit 69ea9cec44b997dd1d5713273ceea86882b940e7
Author: Paul [e-mail]
Date: Thu Sep 5 14:31:37 2019 -0400

Move the VSTGUI.SURGE pointer for linux menus (#1118)

This vstgui.surge turns off the buggy/ghosty/slow linux menu
animation in vstgui

Addresses #1101

still the same behavior

[tank-trax]

you were correct, the changes to #1118 caused it

menus are good here ->

git log
commit c24561ab8a163f6b4036e6c3a54c667e65109f7f
Author: JP Cimalando [e-mail]
Date: Thu Sep 5 15:50:15 2019 +0200

Add xdg-open and zenity commands as Debian dependencies (#1115)

[baconpaul]

Yeah ok. Well that’s good to know! I think not crashing and not ghosting is better than arrow keys with ghosts and crashes but if I get some time
With a Linux vm I will look for 163

[baconpaul]

And thanks for confirming!

[baconpaul]

I found the problem. A misplaced ifdef.

Fix coming shortly. Would really appreciate some testing of course!

[tank-trax]

tested and working as it should, thanks!