Surge: Audio glitching out when turning off "Activate extra scene outputs" if a sound was playing

[VincyZed]

Description:
The audio glitches out continuously when turning off "Activate extra scene outputs" if a sound was playing at the same time.

Here's an example audio file when playing the default saw patch:
glitch.zip

[baconpaul]

So this doesn't happen reliably on the mac but I think the solution is in SurgeVST3Processor if numoutputs ==3 && activated we fill; if numputputs == 3 and not activated, though, we need to zero out the buffer. So that's the code to add (and symmetrically in the VST2).

I'll add that code shortly and then ask you to re-test OK?

[baconpaul]

@VincyZed at your convenience, can you check out branch baconpaul/deactivate-2639 which should fix this problem?

Thanks!

[VincyZed]

@baconpaul Confirmed, it's fixed! Thanks :)

[baconpaul]

Great

[baconpaul]

Merged. Thanks for the test!