Suitecrm: Email Links: Opt-In ticks not shown when email client is set to external

[lazka]

Issue

When the user has set their email client to "External Email Client" all email
links lose their opt-in information (ticks).

This might be the same issue reported in #5859 where resetting the user
settings fixed the issue. It might be that the proposed workaround of
resetting just reset the email setting to "SuiteCRM Email Client".

sugar client:

external client:

Expected Behavior

Changing the email client should not change the display of the email links.

Actual Behavior

Changing the email client removes the opt-in information.

Possible Fix

I've opened a PR #6486

Steps to Reproduce

1. Create a contact
2. Opt-in the contact
3. Opt-in ticks are shown in the contact list
4. Got to your profile and change the email client to external
5. Go back to the contact list

Your Environment

• SuiteCRM Version used: 7.10.10
• Browser name and version (e.g. Chrome Version 51.0.2704.63 (64-bit)): Firefox 63
• Environment name and version (e.g. MySQL, PHP 7): PHP7.2
• Operating System and version (e.g Ubuntu 16.04): Centos 7

[Mausino]

@samus-aran @Dillon-Brown for me this commit https://github.com/lazka/SuiteCRM/commit/001c85061d4f135cb9d9ab441b7b900bf42dc112 working. I see the ticks if i set up in setting the external or suitecrm client.

As is this issue marked as Hight priority and fix is working (for me, should test somebody other also) will great it get milestone 7.0.12 and will fixed in the closest relase.

What do you think ?

[Mausino]

Also i found the pull request #6486 (don't know why i didn't saw it on first time)

[Mausino]

@Dillon-Brown @samus-aran should i ask why when you merge the pull request you did not close the related issue to this merge ?

I am asking only that on other projects which i'm contributing this doing immediatelly after when the pull request is merged.

Because the ticket has label with milestone.. it's immediatelly in milestone to see by status of issues (open/closed) which issues (its patches) was merged & closed and which are open and have not or have the pull requests which are under review process.

[Dillon-Brown]

@Mausino We normally wait until the release is out (E.g. hotfix gets merged into master), that way it will get done automatically. Instead we have the "Resolved: Next Release" label which gets applied when the PR is merged.

Doing it this way makes tracking things much easier imo, because we have multiple different branches its possible for an issue to be resolved in hotfix but not hotfix-7.8.x. It also makes release note creation easier as we don't need to look through tons of closed issued (Some of which might be duplicates) and can instead just sort by the open "Resolved: Next Release" issues.

[Mausino]

@Dillon-Brown thank you for clarification 👍 It's great to see how you're working and i will do the maximum to help in your workflow :)

[Dillon-Brown]

@Mausino Thanks! will likely get easier as time goes on and we really get the process nailed down. I've also started to implement some automation for some of the labels like "Community Contribution" and "Wrong Branch" which I can hopefully expand further to cover more common processes.