Suitecrm: Compose Email button missing from Activities subpannel

[tech-ch1]

After upgrade from 7.10.7 to 7.10.10, after "Activities repair", the "Compose Email" button is missing from the "Activities" subpannel in the Account/Prospect/Contact modules for some users.

This only happens if the user's role does not include "Meeting". All this happens with AJAX modules disabled (because of numerous other bugs.)

Issue

If role allows "Calls" and "Emails" but does not allow "Meeting", only "Calls" is displayed in the activities subpannel. If role allows "Calls", "Emails" and "Meeting", the three buttons are displayed.

Expected Behavior

Email button should be displayed even when meeting is disabled.

Actual Behavior

Email button only displayed if meeting is enabled.

suitecrm.log shows some (maybe unrelated) errors:

Mon Nov 5 16:03:01 2018 [9718][1][FATAL] Mysqli_query failed.
Mon Nov 5 16:03:01 2018 [9718][1][FATAL] Query Failed: SELECT aos_quotes.id AS id FROM aos_quotes WHERE aos_quotes.date_entered >= DATE_ADD(aos_quotes., INTERVAL ) AND (aos_quotes.stage = 'Draft' OR aos_quotes.stage = 'Negotiation' OR aos_quotes.stage = 'Delivered' OR aos_quotes.stage = 'Confirmed') AND aos_quotes.date_entered > '2017-01-17 20:22:32' AND NOT EXISTS (SELECT * FROM aow_processed WHERE aow_processed.aow_workflow_id='39310069-4903-dc6a-83be-587e7dd40c6b' AND aow_processed.parent_id=aos_quotes.id AND aow_processed.status = 'Complete' AND aow_processed.deleted = 0) AND aos_quotes.deleted = 0 : MySQL error 1064: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near ' INTERVAL ) AND (aos_quotes.stage = 'Draft' OR aos_quotes.stage = 'Negotiation' at line 1

Possible Fix

Permission error?

Steps to Reproduce

1. Create role R with permission to Email and Contact modules, and user U with role R.
2. Create some contact C with email address
3. Disable AJAX for Contact module.

4. As user U, go to contact C, see Activities sub-panel, there is no "Compose Email" button.

5. Modify role R and add permissions for Meeting module.

6. As user U, go back to contact C, see Activities sub-panel "Compose Email" and "Meeting" buttons are now displayed.

Context

Worked well in 7.10.7.

Your Environment

• SuiteCRM Version used: 7.10.10
• Browser name and version (e.g. Chrome Version 51.0.2704.63 (64-bit)): Firefox 64.0 64bit
• Environment name and version (e.g. MySQL, PHP 7): php-fpm 7.2, MariaDB 10.1.26
• Operating System and version (e.g Ubuntu 16.04): Debian Stretch 9.0 (stable)

[pgorod]

Any FATAL error is worth solving before worrying about a broken UI behaviour, because the aborted code could be making a difference.

There are a number of recent issues here recognizable by that broken INTERVAL SQL clause, for example #6328 and others linked there.

So this one is likely a duplicate, but it's worth leaving this open until we have a fix for that one, and we can check if it also fixes this one...

[tech-ch1]

Thx, I applied the patch locally and it fixed the problem.

[samus-aran]

Thanks for much @tech-ch1 for confirming that fix worked!