Sts4: [concourse] in_parallel - support both array of steps; and explicit "steps" child

Created on 19 Aug 2019  路  8Comments  路  Source: spring-projects/sts4

image

From https://concourse-ci.org/in-parallel-step.html

in_parallel: ([step] | config)

Two forms of configuration are supported. The simplest form is a simple array of other steps, like so:

in_parallel:
- get: a
- get: b

This is shorthand for the following configuration:

in_parallel:
  steps:
  - get: a
  - get: b

Most helpful comment

Thank you @kdvolder, its working great in our case (using a format like:
```

  • in_parallel:
    fail_fast: true
    steps:

    • task: task-1

      file: task-1.yml

      image: image-1

  - task: task-2
    file: task-2.yml
    image: image-2

All 8 comments

This seems like a good issue to also ask for support of the fail_fast sub-key of the in_parallel step which is marked as YamlSchemaProblem for the same reason.

@mstockd Please create a separate ticket. It's really more convenient to have smaller focussed tasks / fixes than long laundry lists. It's much easier for things to be forgotten and fall through the cracks that way.

@mstockd Actually... never mind that. I'll just take a look at all that seems to be 'new' in the 'in_parallel' schema anyways.

The new 'object-like' format actually has 3 new properties:

  • steps
  • limit
  • fail_fast

Thanks @kdvolder

I was testing the snapshot build a little. The validations are working okay it seems but there's some issues getting completions inside of nested tasks inside of in_parallel. I think it has something todo with the 'funky' schema type that is both a list and a object type at the same time. Doesn't seem to play well with the completion engine. I'll have to debug that a little and see if I can fix.

If anyone wants to give the fix a try, you can download a snapshot .vsix file from this page:

http://dist.springsource.com/snapshot/STS4/nightly-distributions.html

Because of the somewhat strange typing... this was a bit more involved of a fix than the usual little 'schema nitpicks', so I really would appreciate someone to give it good try out. And let us know how it goes.

Thank you @kdvolder, its working great in our case (using a format like:
```

  • in_parallel:
    fail_fast: true
    steps:

    • task: task-1

      file: task-1.yml

      image: image-1

  - task: task-2
    file: task-2.yml
    image: image-2
Was this page helpful?
0 / 5 - 0 ratings

Related issues

playdev-co-kr picture playdev-co-kr  路  10Comments

gsmachado picture gsmachado  路  7Comments

ingogriebsch picture ingogriebsch  路  12Comments

lneumeier picture lneumeier  路  8Comments

imod picture imod  路  11Comments