Status-react: Finish "Show my ENS name in chat" setting in user profile

[churik]

Description

_Type_: Feature
_Summary_: according to ENS call today (notes are here) "Show my ENS name in chat" setting is not related to user nickname and should be applicable for all types of chats and user profile view regardless of the fact user was added to contacts or not.
So, based on https://github.com/status-im/status-react/issues/8765 there are several inconsistencies that should be fixed.

1. Adding user to contacts affects to displaying his name in profile.

It is inherited from a nickname - currently, if the user added to your contacts you are able to see his name.
Now if you are added as contact user will see:




Expected that in all these places will be default username, because "Show my ENS name in chat" setting is off.

2. If "Show my ENS name in chat" setting is on, it should affect all places - public chats, group chats, 1-1 and user profile view

So when the setting is enabled ENS name should be shown in the following places (regardless you are added to contacts or not):

• 2.1. Рreview of 1-1 chat in Home Screen
  
• 2.2. 1-1 chat
  
• 2.3. options in 1-1 chat
  
• 2.4. user profile
  
• 2.3. group chat
  
• 2.4. group info in group chat
  
• 2.5. contacts list
  
• 2.6 preview of chat settings
  

Summary

• [ ] remove link between adding user to contact and displaying of ENS name completely

When setting "Show my ENS name in chat" is on, add ENS name to:

• [ ] preview of 1-1 chat in Home Screen
• [ ] 1-1 chat
• [ ] options in 1-1 chat
• [ ] user profile (full ENS + dafault 3-word random name)
• [ ] group chat
• [ ] group info in group chat
• [ ] contacts list
• [ ] preview of chat settings in ENS name

[churik]

@errorists - please, review it - everything is correct here?

cc @rachelhamlin

[errorists]

Correct! I think we can agree that his is common sense that we should not have inconsistencies in displaying usernames and whichever you selected (displaying ENS name or not) in the setting should populate everywhere a username is used. It's not merely a replacement for the current display name scheme, it's a new global identifier that you can choose to broadcast publicly or not.

[errorists]

@churik by the way a question if you will, in the latest Jenkins build, when I toggle 'Show my ENS username in chats' the preview below it doesn't update to match the setting, it always shows my random funny name, is that a known bug? it should show the ens username when toggled on.

[churik]

I'll add it to description. Thanks for noticing.

[errorists]

can i drop this here and ask kindly whomever is working on this to address those. you're awesome.

[flexsurfer]

thanks @errorists

[flexsurfer]

Summary

• [x] remove link between adding user to contact and displaying of ENS name completely

When setting "Show my ENS name in chat" is on, add ENS name to:

• [x] preview of 1-1 chat in Home Screen
• [x] 1-1 chat
• [x] options in 1-1 chat
• [x] user profile (full ENS + dafault 3-word random name)
• [x] group chat
• [x] group info in group chat
• [x] contacts list
• [x] preview of chat settings in ENS name

[flexsurfer]

| 1-1 chat in Home Screen | 1-1 chat | options in 1-1 chat |
| ------------- | ------------- | ------------- |
| | | |

[flexsurfer]

| user profile | contacts list | preview in ENS name |
| ------------- | ------------- | ------------- |
| | | |

[churik]

@churik
TC 6226 should be completed in scope of this PR.

related to https://github.com/status-im/status-react/pull/9428

[flexsurfer]

| group chat | group info in group chat |
| ------------- | ------------- |
| | |