Status-react: Custom picture is not applied to login screen

Created on 22 Aug 2019  Â·  9Comments  Â·  Source: status-im/status-react

Problem

Custom picture is not applied to login screen

Steps

  • open status
  • profile -> change user picture
  • logout

Pay attention to the picture when logged out. Also go to Unlock screen and check it there.

Actual result: default picture is shown

image

build: nightly 22-Aug-2019

bounty-s bug medium-priority medium-severity

All 9 comments

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


__This issue now has a funding of 80.0 DAI (80.0 USD @ $1.0/DAI) attached to it.__

All yours @tbenr! Thanks for applying.

@tbenr scope change - let's leave the image off of the unlock screen, for privacy reasons. It needs to be fixed only on the profile screen.

We don't want users to have any personally identifying information on the unlock screen + are willing to make the trade off of not being able to identify their account(s) as easily, since multiple multi-accounts is not a use case we're designing for.

@StatusSceptre that's right.

But it's not really clear which part has to be fixed..

do we need to call multiaccounts_updateAccount as per https://github.com/status-im/status-go/issues/1634#issuecomment-542183585 to save image at statusgo side?

which part of profile screen is not working? yesterday I did a quick test and on profile the image was persisted correctly. Not 100% sure btw..

@asemiankevich need help understanding is there is actually something to fix.. can you help?

Tested on nightly just now, iOS and it's not an issue for me either. I'll close this one. Sorry for the wasted effort @tbenr! I'll email you.

@tbenr Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • [x] reminder (3 days)
  • [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

Issue Status: 1. Open 2. Cancelled


__Workers have applied to start work__.

These users each claimed they can complete the work by 3 weeks, 2 days from now.
Please review their action plans below:

1) tkembo has applied to start work _(Funders only: approve worker | reject worker)_.

I'm now sure yet but I've been working with React for a while - I can figure out what the issue is

Learn more on the Gitcoin Issue Details page.

Issue Status: 1. Open 2. Cancelled


__The funding of 80.0 DAI (80.0 USD @ $1.0/DAI) attached to this issue has been cancelled by the bounty submitter__

Was this page helpful?
0 / 5 - 0 ratings