Status-react: Cannot delete dapp from "Recent"

Created on 2 Jul 2019  Â·  22Comments  Â·  Source: status-im/status-react

Description

Type: Bug

Summary: cannot use swipe and delete gesture to remove last visited dapps - when tap on "Delete", nothing happens (Android only). In chat it was replaced with long tap > delete , IMO it will be better to have this behavior for dapps as well.

Expected behavior

can delete browser entry

please see comments from @flexsurfer on the issue:
maybe related to native animation, but anyway we need to change it on long press

"Clear all" also should be implemented

Actual behavior

nothing happens

Reproduction

  • Open Status
  • Open "DApps"
  • Open any dapp and go back to main "DApps" screen
  • Below "Recent" swipe to delete visited dapp from history

Additional Information

  • Status version: nightly 02/07/2019
  • Operating System: Android 8
bounty-s bug core-ui-grooming e2e test blocker high-priority medium-severity

All 22 comments

maybe related to native animation, but anyway we need to change it on long press

cc @rachelhamlin

I'm going to put a bounty on this. @flexsurfer s or xs?

s if we're talking about implementing long-press and clear all feature

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


__This issue now has a funding of 80.0 DAI (80.0 USD @ $1.0/DAI) attached to it.__

Issue Status: 1. Open 2. Cancelled


__Work has been started__.

These users each claimed they can complete the work by 2 months from now.
Please review their action plans below:

1) elegant651 has applied to start work _(Funders only: approve worker | reject worker)_.

I'll look into browser codes for resolving this issue.
2) sesamestrong has been approved to start work.

This seems feasible; I will look into it and hopefully fix the bug!

Learn more on the Gitcoin Issue Details page.

I haven't started any development yet, but as of now, the swipe-and-delete functionality works both in an emulator (BlueStacks on Windows 10, as of 8/19/2019 3:40 EST on the Google Play Store release) and on an Android phone. Although part of the bounty is for adding long-press functionality, the part about fixing the bug is no longer necessary.
The video from the emulator (identical to what happens on mobile) is here.

@Sesamestrong thanks for looking into it - I've approved you for work, are you clear on the remaining task to change the functionality to long press? :)

Yes I am, thanks!

@sesamestrong Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • [x] reminder (3 days)
  • [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@sesamestrong Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • [x] reminder (3 days)
  • [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


@sesamestrong due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

  • [x] reminder (3 days)
  • [x] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


@sesamestrong due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

  • [x] reminder (3 days)
  • [x] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

Hey @Sesamestrong! You still on this one?

Yes I am; sorry for the inactivity; in the rush of getting back to school, the bounty never crossed my mind. I'm still happy to work on it!

@Sesamestrong that'd be great. Let me know if we can help.

@sesamestrong Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • [x] reminder (3 days)
  • [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@sesamestrong Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • [x] reminder (3 days)
  • [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


@sesamestrong due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

  • [x] reminder (3 days)
  • [x] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


@sesamestrong due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

  • [x] reminder (3 days)
  • [x] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

Issue Status: 1. Open 2. Cancelled


__The funding of 80.0 SAI (80.0 USD @ $1.0/SAI) attached to this issue has been cancelled by the bounty submitter__

Was this page helpful?
0 / 5 - 0 ratings

Related issues

jakubgs picture jakubgs  Â·  44Comments

flexsurfer picture flexsurfer  Â·  45Comments

rachelhamlin picture rachelhamlin  Â·  49Comments

jakubgs picture jakubgs  Â·  174Comments

churik picture churik  Â·  52Comments