Status-react: Beta alert on upgrading

Created on 27 Feb 2019  路  21Comments  路  Source: status-im/status-react

We currently show a Beta alert, informing users that the app they are using is in Beta.

Copy wass updated end of Feb.
Issue https://github.com/status-im/status-react/issues/7400
PR https://github.com/status-im/status-react/pull/7540

The alert is currently shown on:

  • Recover account
  • Create additional account
  • Create new account

We want to show this alert also to users after upgrading to a new version of Status to inform them and reassert that the app is in Beta.

  • [ ] recovering account on older release, upgrade to current PR -> warning (with autologin enabled)
  • [ ] creating account on older release, upgrade to current PR -> warning (with autologin enabled)
  • [ ] recover account on older release upgrade to current PR -> warning
  • [ ] creating account on older release, upgrade to current PR -> warning
UUX improvements bounty-s login low-severity

All 21 comments

cc @mandrigin @rachelhamlin

Can we bounty this one as well? Also noticing that the copy update hasn't been merged for v.0.10.0.

Can we bounty this one as well? Also noticing that the copy update hasn't been merged for v.0.10.0.

@rachelhamlin we are merging https://github.com/status-im/status-react/pull/7540 to v 0.10.0. Is it a problem?

Nope, totally okay to merge the copy change. Thanks @annadanchenko!

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


__This issue now has a funding of 80.0 DAI (80.0 USD @ $1.0/DAI) attached to it.__

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


__Work has been started__.

These users each claimed they can complete the work by 10聽months, 3聽weeks from now.
Please review their action plans below:

1) e18r has been approved to start work.

As a long-term SNT holder, I'd love to finally be able to contribute to the develoment of Status.

  • I've cloned the repo, read the documentation and joined the #status-core-devs chat on Status.

  • For the past few days, I've been learning Clojure on braveclojure.com. I find the jokes rather distasteful, but I've done every single exercise so far, and I'm pretty excited about this new language. You can follow my progress here: https://github.com/e18r/clojure-noob.git

  • I've set up the development environment on my Arch Linux machine. I think I can do a few pull requests to improve the build scripts and documentation for setups on Arch Linux. I managed to get everything working on an AVD.

  • I haven't been able to make it work on a real Android phone. Figwheel never connects to my app. I need help with this.

I hope to be able to tackle this issue!

Learn more on the Gitcoin Issue Details page.

Hey @StatusSceptre, who will manage Gitcoin moving forward?

@rachelhamlin, Corey and Andy.

Hi, thanks for accepting me. I already managed to solve my development environment issues and I'm already at the beginning of chapter 5 of the Brave Clojure book. I'll start working on this tomorrow morning!

Today I took a look at the source code, and particularly at the function show-mainnet-is-default-alert from src/status_im/accounts/core.cljs. There I realized that the beta warning is not enabled in my environment because I'm obviously not on mainnet. That realization took me to the file src/status_im/utils/config.cljs which loads config options from the namespace status-im.react-native.js-dependencies. I changed the name of the require just to generate an error that could give me a clue as to where that namespace comes from. If I interpreted that error correctly, it comes from a JavaScript source.

So as you can see, I'm working my way up this project slowly but surely. Any hints super welcome. Gonna keep working tomorrow.

Today I figured out a way to accomplish what is expected.

In the accounts database, a boolean entry called mainnet-warning-shown? stores whether the beta alert was already shown to a certain user. I'm going to modify that entry into a string called mainnet-warning-shown-version, which will store the version of status that the beta alert was shown in. That way, knowing the current version and the value of that db entry, it will be possible to determine if the beta alert was shown in the current version and act accordingly.

I created a new entry with that name in the file src/status_im/accounts/db.cljs, but it doesn't seem to be storing anything. Perhaps I need to perform some sort of migration? Tomorroy I will research about data stores in react native, or clojure, or android. Any hints welcome!

Thanks for sharing your progress @e18r! I'm not the right person to give you hints. However, please try the channel #status-core-help https://get.status.im/chat/public/status-core-help

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


__Work for 80.0 DAI (80.0 USD @ $1.0/DAI) has been submitted by__:

  1. @e18r

@StatusSceptre please take a look at the submitted work:

  • PR by @e18r

Hello @hesterbruikman, @rachelhamlin, @StatusSceptre, @churik, Corey and Andy:

Have you got the time to check out my pull request? Here it is in case you missed it: PR

Please let me know if you encounter anything unusual. Thanks!

@e18r thanks for pinging us! Posting in Status, or @corpetty can you review?

@rachelhamlin not sure what to do with bounty.
https://github.com/status-im/status-react/pull/7862 fixes issue for Android only.
Should I create another one for IOS?

I think that's the best bet @churik.

Hi @rachelhamlin, let me know if anything remains to be done. Otherwise please don't forget to make the payment. Thank you!

I'm sorry about the delay @e18r! I actually don't control the purse strings on gitcoin. @corpetty could you pay this one out for us?

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


__The funding of 80.0 DAI (80.0 USD @ $1.0/DAI) attached to this issue has been approved & issued to @e18r.__

@rachelhamlin thank you so much for your support. Until next time!

Was this page helpful?
0 / 5 - 0 ratings