Status-react: User can open own profile from system messages or from group info

[churik]

Description

Type: Bug

Summary: after user has been made admin he can open own profile from group info screen

Expected behavior

user can't open own profile screen from group Group info

Actual behavior

can see own profile with options, that cannot be performed

Reproduction

_Scenario 1 (for group info):_

• Open Status on (device A, user A)
• Create a group chat (device A, user A) with user B
• Make User B admin
• Log in to Status (device B, user B)
• Open group chat with user A
• Tap on ... > Group info
• Tap on ... > Open Profile on your avatar

_Scenario 2 (for system messages):_

• Open Status on (device A, user A)
• Create a group chat (device A, user A) with user B
• Tap on own avatar on message *user A* created a group.

Additional Information

• Status version: nightly 28/12/2018
• Operating System: all
• Video: http://take.ms/Y9qI6

[churik]

@cammellos look at this one when you have a time.

[churik]

cc @rachelhamlin
I'm not sure that it is required, but anyway, user can try to block yourself, I don't think it is desirable.

[rachelhamlin]

Easier to disable, agreed! Probably an xs bounty.

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

__This issue now has a funding of 50.0 DAI (50.0 USD @ $1.0/DAI) attached to it.__

• If you would like to work on this issue you can 'start work' on the Gitcoin Issue Details page.
  
  
  
  • Want to chip in? Add your own contribution here.
  
  
  • Questions? Checkout Gitcoin Help or the Gitcoin Slack
  
  
  • $144,315.97 more funded OSS Work available on the Gitcoin Issue Explorer
  
  

[gitcoinbot]

💰 A crowdfund contribution worth 0.01000 DAI (0.01 USD @ $1.0/DAI) has been attached to this funded issue from @intan167.💰

Want to chip in also? Add your own contribution here.

[rachelhamlin]

@speedyFixer are you still interested and available to work on this issue? Just assigned you! Apologies for delay.

[speedyFixer]

Hi @rachelhamlin , I'm traveling, I will go back on Saturday, so I will can tackle all of this on Sunday. Is It OK?

[rachelhamlin]

@speedyFixer sure! I'll make a note to follow up next week. You have the go-ahead on Gitcoin.

[speedyFixer]

Great! :)

[gitcoinbot]

@speedyfixer Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• [x] reminder (3 days)
• [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[gitcoinbot]

@speedyfixer Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• [x] reminder (3 days)
• [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[speedyFixer]

Hi @gitcoinbot I will start to work on Sunday.

[speedyFixer]

Hi @gitcoinbot , I'm back from my travel, I will work on this today.

[rachelhamlin]

Go go @speedyFixer :) thanks for checking in.

[gitcoinbot]

@speedyfixer Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• [x] reminder (3 days)
• [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[gitcoinbot]

@speedyfixer Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• [x] reminder (3 days)
• [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[speedyFixer]

Hi @rachelhamlin , I have a lot of problems getting the status react app running with the latest changes, I don't know if something is broken in https://dev-docs.status.im/build_status/

I refreshed the repo with the lastest changes in Status and react-native run-android didn't work, I realized Gradle was missing in my system, so I installed Gradle 5.0, but no luck when I run react-native run-android, now the error showed is:

Build file '/home/sf/Developments/status-react/android/build.gradle' line: 51

* What went wrong:
A problem occurred configuring project ':@react-native-community_netinfo'.
> STATUS_GO_ANDROID_LIBDIR environment variable is not valid!

Hi @PombeirP , Could you give me a clue, Is this a nix problem? am I doing something wrong?

I appreciate any help! @gitcoinbot I'm working, but I'm stuck in this problem.

[pedropombeiro]

Hi @speedyFixer. That link seems to point to an out-of-date version of the documentation. Please use https://status.im/build_status/ instead. We have a reproducible build environment in place based on Nix, so you shouldn't use tooling outside of the Nix environment. Using the recommended Makefile targets will ensure you're using Nix for your tasks. E.g. instead of running react-native run-android on the shell, you should run make run-android.

[jakubgs]

I've taken down https://dev-docs.status.im/ entirely. I must have missed it when we moved docs under https://status.im/docs/. Not even sure how @speedyFixer found that URL, since we never publicized the pages with dev-* prefix, which were essentially staging for changes.

[jakubgs]

Pretty sure this is a more up-to-date guide: https://status.im/build_status/status_react_quickstart.html

[speedyFixer]

Hi, really thanks @PombeirP and @jakubgs ! I didn't realize about the outdated docs, I use to use the new docs with no problem. I always look for the documentation before run the project for what I typed in Google 'status im docs', and the results lead me to the outdated docs.

I did a video with the behavior:
https://www.youtube.com/watch?v=UeH7e6Gu6As

This simple issue made me waste a lot of time, Now I'm going to check with the new docs. Thanks again!

[jakubgs]

Thanks for pointing that out, it does indeed lead you to the dev page. I've updated the sitemap URL in the Google Search Console, it might take a bit for the results to change but they should be correct soon.

But I've also verified that Google doesn't list the site itself and it says it does:

I've temporarily put up the site with just a robots.txt with Disallow: / and forced a re-indexing.
I'll check up on this on Monday and see if it's fixed.

[jakubgs]

Added a 301 redirect from dev-docs.status.im to status.im/docs: https://github.com/status-im/infra-misc/commit/9c38229d

[gitcoinbot]

@speedyfixer Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• [x] reminder (3 days)
• [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[gitcoinbot]

@speedyfixer Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• [x] reminder (3 days)
• [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[speedyFixer]

Thanks @jakubgs , I was able to lauch status react with the new docs, right now I'm a bit busy with work stuff, Just FYI, I will can check this issue on the weekend.

[rachelhamlin]

@speedyFixer doing a sweep of all our bounties. This weekend sounds good! Thanks for the update.

[gitcoinbot]

@speedyfixer Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• [x] reminder (3 days)
• [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[gitcoinbot]

@speedyfixer Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• [x] reminder (3 days)
• [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

@speedyfixer due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

• [x] reminder (3 days)
• [x] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

@speedyfixer due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

• [x] reminder (3 days)
• [x] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[speedyFixer]

I'm back! Thanks for waiting :)

[rachelhamlin]

Hey @speedyFixer! Just checking in to see how things are going.

[gitcoinbot]

@speedyfixer Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• [x] reminder (3 days)
• [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[speedyFixer]

Hi @rachelhamlin I wasn't able to reproduce the issue with emulator, I will try again this weekend with two real devices or maybe was the status version. Sorry for forget add a progress message here.

[rachelhamlin]

That's okay. I had a really weird freeze while trying to test this situation.

_Edit: This happened on the the biometric PR branch from 4/10._

1. Create a group chat and invite yourself with another account.
2. Make your other account an admin.
3. Login to your other account.
4. Open the new group chat—you will see that you've been made admin, as well as 'Join Group' or 'ignore invite' options.
5. 'Join group' and this error happens, followed by app freeze 😬

I'm now attempting to run through the situation again with a new group chat, and the invitation's not coming through to my second account.

@speedyFixer let's pause work on this. I'm considering disabling group chat for v1; it's too janky. If you'd like to take a crack at something else, I can share some ideas. :)

[speedyFixer]

Ok I'm going to stop in Gitcoin, Yes @rachelhamlin , I would like :)

[rachelhamlin]

@speedyFixer cool! Any of these interest you?

https://github.com/status-im/status-react/issues/8998
https://github.com/status-im/status-react/issues/8940
https://github.com/status-im/status-react/issues/8930
https://github.com/status-im/status-react/issues/8877
https://github.com/status-im/status-react/issues/8718
https://github.com/status-im/status-react/issues/8662

[speedyFixer]

8877 sounds good :)

[rachelhamlin]

@speedyFixer I added a bounty to #8877 - go for it!

[speedyFixer]

Thanks @rachelhamlin , I stopped work on Gitcoin.

[gitcoinbot]

Issue Status: 1. Open 2. Cancelled

---

__Work has been started__.

These users each claimed they can complete the work by 2 months from now.
Please review their action plans below:

1) iamserver has been approved to start work.

will find the bug and fix it if you give me the permission to proceed

Learn more on the Gitcoin Issue Details page.

[rachelhamlin]

Hey @iamserver - apologies for my delay, I missed that you applied, but you're approved to start work if you're still interested.

[gitcoinbot]

@iamserver Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• [x] reminder (3 days)
• [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[iAmServer]

Am in

[gitcoinbot]

@iamserver Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• [x] reminder (3 days)
• [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[gitcoinbot]

@iamserver Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• [x] reminder (3 days)
• [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[rachelhamlin]

Hey @iAmServer! Checking in. Are you still on this one?

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

@iamserver due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

• [x] reminder (3 days)
• [x] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

@iamserver due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

• [x] reminder (3 days)
• [x] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[StatusSceptre]

Hi @iAmServer are you still working on this issue?

[churik]

Still relevant in nightly 25/02/2020

[churik]

fixed in #10099

[gitcoinbot]

Issue Status: 1. Open 2. Cancelled

---

__The funding of 50.0 SAI (plus a crowdfund of 0.01 DAI worth 0.010038660500000001 USD) (50.0 USD @ $1.0/SAI) attached to this issue has been cancelled by the bounty submitter__

• Questions? Checkout Gitcoin Help or the Gitcoin Slack
• $134,900.15 more funded OSS Work available on the Gitcoin Issue Explorer