Status-react: Use react-native-fast-image for remote images

Created on 1 Mar 2019  ·  45Comments  ·  Source: status-im/status-react

In stickers and in extensions we load remote images and react native image works not perfect, react-native-fast-image has much better performance and better to use it for remote images

https://github.com/DylanVann/react-native-fast-image

feature

All 45 comments

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


__This issue now has a funding of 80.0 DAI (80.0 USD @ $1.0/DAI) attached to it.__

@StatusSceptre could you approve @shamardy

@StatusSceptre any update here? @yenda should I create a PR and start work until I get approved?

@shamardy yes
@flexsurfer please find someone to approve him

Hey @yenda and @flexsurfer - @shamardy has been approved.

@shamardy Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • [x] reminder (3 days)
  • [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@shamardy Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • [x] reminder (3 days)
  • [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


@shamardy due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

  • [x] reminder (3 days)
  • [x] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


@shamardy due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

  • [x] reminder (3 days)
  • [x] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

Hey @shamardy - double checking, are you done with this issue?

Hey @kilimanjaro2 I know this is from ages ago, but if you have bandwidth & are interested, I've just approved you to work on this bounty.

Hi Rachel.

I still want to get my hands dirty with open source contribution. Id like
to take this up.

On Tue, Sep 3, 2019 at 5:53 AM Rachel Hamlin notifications@github.com
wrote:

Hey @kilimanjaro2 https://github.com/kilimanjaro2 I know this is from
ages ago, but if you have bandwidth & are interested, I've just approved
you to work on this bounty.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/status-im/status-react/issues/7633?email_source=notifications&email_token=AD3PN5OEV4GURRYKVTP3QSDQHY64DA5CNFSM4G3CIWLKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5XZZ4I#issuecomment-527408369,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AD3PN5IPNTU5SZU766A6UEDQHY64DANCNFSM4G3CIWLA
.

--

Thank You
Arun H Garimella

This Is Anfield
YNWA

@kilimanjaro2 great! You can take a look at the PR from shamardy that was not finished - hopefully not too difficult to complete. Let us know if you have any questions.

@kilimanjaro2 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • [x] reminder (3 days)
  • [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

Heyo @kilimanjaro2, you still on this one?

Yes. I'll start working on it this weekend. I have a lot on my plate during
the week.

On Tue 10 Sep, 2019, 04:06 Rachel Hamlin, notifications@github.com wrote:

Heyo @kilimanjaro2 https://github.com/kilimanjaro2, you still on this
one?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/status-im/status-react/issues/7633?email_source=notifications&email_token=AD3PN5PUHB4JGQSIRECKH73QI5PP7A5CNFSM4G3CIWLKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6KMU6Q#issuecomment-529844858,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AD3PN5NH4NQTVPK4PM4NVWDQI5PP7ANCNFSM4G3CIWLA
.

@kilimanjaro2 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • [x] reminder (3 days)
  • [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


@kilimanjaro2 due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

  • [x] reminder (3 days)
  • [x] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@rachelhamlin could i take this bounty? i have expirence with RN :)

Yes please. I forgot about it, in fact.

On Wed 16 Oct, 2019, 18:05 Miguel Angel Gordián, notifications@github.com
wrote:

@rachelhamlin https://github.com/rachelhamlin could i take this bounty?
i have expirence with RN :)


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/status-im/status-react/issues/7633?email_source=notifications&email_token=AD3PN5PAXODC3ODKZ4QAKDDQO6M5FA5CNFSM4G3CIWLKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBOGQJQ#issuecomment-542926886,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AD3PN5JRTDN2EI5TEWQPRUTQO6M5FANCNFSM4G3CIWLA
.

Sure @zoek1, can you please apply on gitcoin? Let us know if you have any questions. Welcome!

@zoek1 also if you'll work in this you can use this PR https://github.com/status-im/status-react/pull/8399

@zoek1 you're approved for the issue on gitcoin. 👍

@zoek1 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • [x] reminder (3 days)
  • [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@zoek1 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • [x] reminder (3 days)
  • [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

Yep, i just finish the setup of the project. I'll start working on this right now. :grinning:

@zoek1 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • [x] reminder (3 days)
  • [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@zoek1 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • [x] reminder (3 days)
  • [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

I'm still working on this, i just need click the stop button at the issue to submit other work. I'll post my updates between today and tomorrow.

Sounds good @zoek1 - thanks for the update.

Hey @zoek1! Just checking in, how is this going for you?

Hi @zoek1 are you planning to finish this issue?

i've tested react-native-fast-image library and can't really see any advantage for status app, and also local images don't work https://github.com/DylanVann/react-native-fast-image/issues/410, so i'll close this issue

Issue Status: 1. Open 2. Cancelled


__Workers have applied to start work__.

These users each claimed they can complete the work by 2 weeks, 5 days ago.
Please review their action plans below:

1) debragail has applied to start work _(Funders only: approve worker | reject worker)_.

switching out react native image for -fast and test performance

Learn more on the Gitcoin Issue Details page.

@jimmydjabali Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • [x] reminder (3 days)
  • [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

Yeah I just had big troubles to get used to compile with nixOS's system. Now it's okay and it should be finished in just a few days.

@jimmydjabali Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • [x] reminder (3 days)
  • [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


@jimmydjabali due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

  • [x] reminder (3 days)
  • [x] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

probably we should give one more chance to this issue and consider https://developers.google.com/speed/webp/ for stickers @Ferossgp @errorists

@flexsurfer if we all agree to use webp, I can run all of our stickers through the converter app

@flexsurfer as you self-assigned, can I remove the bounty from this issue on Gitcoin?

yes, thanks

Issue Status: 1. Open 2. Cancelled


__The funding of 80.0 DAI (80.0 USD @ $1.0/DAI) attached to this issue has been cancelled by the bounty submitter__

I believe this one has now been fixed.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

chadyj picture chadyj  ·  53Comments

errorists picture errorists  ·  40Comments

rachelhamlin picture rachelhamlin  ·  49Comments

chadyj picture chadyj  ·  92Comments

jakubgs picture jakubgs  ·  174Comments