Spoke: Feature Request: Tags - Click to Add/Remove

[ryanjcrump]

Problem
We are seeing tag errors due to folks either forgetting to click the button to save tags, or not scrolling down to find that button, which causes additional training and reminding for new texters as well as experienced texters who are not used to our increased focus on tags for contact information updates.

Solution
Now that we have the ability to remove tags from messages, a Tag should be added to a conversation immediately when clicked and highlighted. A Tag should be removed from a conversation immediately when clicked and unhighlighted.

[arena]

labeling this ... definitely agree that the texting UI needs a refinement pass

[ibrand]

@schuyler1d would it be too backwards incompatible to remove the "save tags" button all together? I think that would make for a nicer experience.

[earthtone0ne]

I'd like to take this, assuming it's still "help wanted". It'll be my first venture into Spoke :)

I think @ibrand 's suggestion to remove the button makes sense. If we're concerned about confusing existing users, maybe replace it with messaging like "Click to apply/remove tags" or "✓ Changes saved"?

[ryanjcrump]

Yes! Thanks Stephanie!

On Wed, Oct 14, 2020 at 11:57 AM Stephanie [e-mail] wrote:

I'd like to take this, assuming it's still "help wanted". It'll be my
first venture into Spoke :)

I think @ibrand https://github.com/ibrand 's suggestion to remove the
button makes sense. If we're concerned about confusing existing users,
maybe replace it with messaging like "Click to apply/remove tags" or "✓
Changes saved"?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/MoveOnOrg/Spoke/issues/1779#issuecomment-708597216,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AQX2MVCA3TFH6XLNYWWGQC3SKXYA3ANCNFSM4QMGG7KA
.

>

Sent from Gmail Mobile

[Frydafly]

Progress on this? @earthtone0ne
I remember seeing a figma mock-up from @arena

[arena]

I believe there are some strong arguments for keeping the explicit "save" after changing tags.

I kinda hate to make things more cumbersome, but maybe we should interrupt texters with a confirmation/warning modal that lets them confirm or cancel the tagging they've done if they haven't saved before they send and auto-advance to the next convo or go back to the dashboard.

If it's not necessary to have the save button, that's better, but I think it is.
I think @schuyler1d can clarify why.

[joemcl]

I support @ryanjcrump in a need for one-click tagging. If an organization really wants to have a two-click process, IE, also require clicking on Save, make that an option.

[arena]

You could do something as simple as have a count of how many tags are applied to handle the common (awkward) situation where a messaging campaign only has one tag

and then as tags are applied you could sum that up, or in the case of the one tag reiterate that it's been applied in case the visual change is not enough to be clear

[schuyler1d]

Sorry I haven't replied earlier. I don't think it's backwards incompatible to remove 'Save Tags' and automatically save, however that creates a different issue which is that texters do not have access to remove tags. I think we could reconsider allowing that as long as it's reserved for 'texter tags' (i.e. they can't remove arbitrary tags some might even be flagging the texter themselves).

[arena]

Ideally, texters wouldn't even see tags that they couldn't apply/remove (and then we don't have to worry about how to display those tags in a way that makes them feel not-buggy).

[schuyler1d]

Agreed! I think the issue is that currently no one can remove a tag -- but instead we only mark it 'RESOLVED' if it's complete -- so the question is should a texter be able to mark something resolved after they tag it? Maybe. If so, It just means adding that actual check to the system, instead of just semi-enforcing it by the listing they see rather than doing a permissions check on what tag it is.

Things we'd need to do on the backend:

• probably add 'tag.group' to the cache here: https://github.com/MoveOnOrg/Spoke/blob/main/src/server/models/cacheable_queries/tag-campaign-contact.js
• probably add organization tags to the organization cache including group.
• Have this filter use the above cache: https://github.com/MoveOnOrg/Spoke/blob/main/src/server/api/organization.js#L115-L124
• add an additional permission check based on whether it's a texter tag here: https://github.com/MoveOnOrg/Spoke/blob/main/src/server/api/mutations/updateContactTags.js#L22 (after loading what kind of tag it is from hopefully the cache)

Then on the front-end, all the changes would be in:
https://github.com/MoveOnOrg/Spoke/blob/main/src/extensions/texter-sideboxes/tag-contact/react-component.js
where you'd

• 'delete' uncheck a tag by sending value: "RESOLVED"
• remove save tags button
• onClick of a tag should trigger an immedate mutation -- maybe abstract that to functions for easier readability
• other UI pieces discussed in this thread