Spoke: +1 Required Before Phones

[alyjk]

On my system a +1 is required before phone numbers in the CSV that we want to upload. 10 digits by themselves aren't currently working. Since we often have a mix of +1 and the regular 10 digit numbers it would be great to be able to have them go into Spoke either way. Is anyone else having this problem?

[shakalee14]

I've only seen this problem when you're directly querying a data warehouse (if you have that feature connected). Not for CSVs though.

[ibrand]

@schuyler1d is this something we should check for in the ingest library? If so, maybe that could be a mini PR that someone could write? Then the numbers would be normalized for all ingest methods

[schuyler1d]

I believe this issue can be closed.
Csv Uploads are reformatted with
https://github.com/MoveOnOrg/Spoke/blob/main/src/lib/phone-format.js

I do list it as an ingest loader responsibility (and think I test for this in csvupload tests but if not I'll add it)
I suppose we could check for a + prefix but the software is international so we can't just assume a +1

[bchrobot]

For what it's worth, we observed problems with phone format utils in the client when PHONE_NUMBER_COUNTRY was not present at build time. Looks like this was fixed, at least for Docker, in 33e2edcc455836f36eafd56d585430ac1ceda515.

[ibrand]

Closing this since it seems to not be an issue anymore. Thanks everyone!