Spoke: TEXTER: Texter able to send "blank" text message

[Dayologic]

Description: The user is able to enter and send spaces in the "your message" field as a response to the user

ENV: STG
Browser: CHROME (latest)
OS: MacOS V10.12.5
Priority: LOW

Steps To Reproduce:

1) Login to Spoke Admin
2) Create A Campaign
3) Switch to texter view
4) Send message to texter
5) Verify/Receive a response
6) In "Your Message" field enter a few blank spaces and select send

Expected Result: The field validation recognizes that a valid response hasn't been sent

Actual Result: The system treats the spaces entered a valid character.

Low Priority As The User Doesn't Actually Receive the Blank Message - but it impacts the admin texter flow as you'll have to wait for the user to respond before being able to send accurate messaging.

SCREENSHOT:

[darvelo]

I'm working on this issue, now writing a test (will squash commits after). I'm trying to simulate a button click using enzyme's simulate(), but it's not working. The codebase doesn't use simulate() anywhere… is it due to the bug mentioned in this comment?:

  // These are an attempt to confirm that the buttons will work.
  // It would be better to simulate clicking them, but I can't
  // get it to work right now because of 'react-tap-event-plugin'
  // some hints are here https://github.com/mui-org/material-ui/issues/4200#issuecomment-217738345

I'm going to install the Docker environment so I can run the full tests, and it looks like my change may break an end-to-end test. Is the test I'm writing better suited for e2e if simulate() isn't working?

[ibrand]

@darvelo did you end up finishing that PR ^? If not, do you have a WIP branch that someone could take to the finish line?

[darvelo]

@ibrand I do have a WIP branch up, though unfortunately I won't have any time to work on it. It can be found here: https://github.com/MoveOnOrg/Spoke/compare/main...darvelo:587-disallow-empty-texter-message

[ibrand]

Thank you! If anyone wants to take this change to the finish line, looks like that WIP branch is mostly done and just needs a few edits on the tests

[jasterix]

I'd like to work on this issue