Sp-dev-fx-webparts: react-rss-reader - ampersands (&) not being decoded in links

[furler]

Category

• [ ] Question
• [x] Bug
• [ ] Enhancement

Authors

@VesaJuvonen

Expected or Desired Behavior

I have RSS feeds where if an ampersand is in the link/title it is encoded as "&" - I believe this is correct for RSS/XML feeds, however the web part does not decode them, so they are displayed as "&" instead of "&" like they should

Observed Behavior

"&" is rendered as is, instead of being converted to "&"

Steps to Reproduce

Any RSS feed that contains "&" in a title

[msftbot[bot]]

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

[hugoabernier]

@furler the author for this sample is @ericoverfield, not Vesa.

[AbhishekGarg]

@eoverfield
Calling a small decode function for each ListRow item (reference from an old stackoverflow answer) might be useful in solving this issue.

If this seems like a good idea, I can send in a PR.
Example of feed having '&' in an item's title: https://www.pbs.org/wgbh/nova/rss/all/

[furler]

@eoverfield
If this seems like a good idea, I can send in a PR.
Example of feed having '&' in an item's title: https://www.pbs.org/wgbh/nova/rss/all/

This would be most appreciated - as I mentioned, decoded ampersands are correct RSS - and I just happen to be using this to grab headlines mentioning the company I work for, which, can you guess, has an ampersand in its name.

[AbhishekGarg]

@eoverfield your thoughts please.

[eoverfield]

@AbhishekGarg please submit that PR if you could. Thank you for finding and reporting.

[hugoabernier]

@AbhishekGarg I've assigned this one to you so no one else steals it from you 😀

I'll make sure to process the PR quickly. Thanks for contributing!