Sourcegraph: Query builder should show query in search box

[felixfbecker]

The query builder does currently not show the built query in the search box. This is a missed opportunity for teaching people how to achieve the query with direct search syntax. It is also confusing, because the query builder does not have a Submit button, but the "Search" submit button is implied to submit what is in the search box, not the query builder.

I propose it makes the search box readonly and updates its contents.

[sqs]

Let's get more user feedback on the query builder before prioritizing/making this change. There is one other direction (that I consider fairly likely) that would preclude this specific change:

• Making the query builder always visible like https://cs.chromium.org/. Then we could not have this simple behavior of "if query builder is visible, make main search bar readonly"

Adding @francisschmaltz for user research on this.

[felixfbecker]

Personally I am -1 on that because it makes the UI less clean/tidy.

But I think it would be good idea to remember the open state in localStorage for people who always prefer the query builder

[francisschmaltz]

I agree with Felix that it shouldn't be always visible. The 1 way binding we previous discussed would be the right thing to do here.

[attfarhan]

Query builder is feature flagged off by default and will be removed, so closing.