Sourcegraph: Too many Sourcegraph extensions wreck GitHub toolbar UI

Created on 13 Jun 2019  路  3Comments  路  Source: sourcegraph/sourcegraph

https://github.com/sourcegraph/sourcegraph/blob/master/browser/src/libs/github/file_info.ts#L22

Screen Shot 2019-06-12 at 3 28 05 PM

I would break this issue into two parts:

1) What can we do to the extensions to make them take up less space?

  • Change the button text of the code-ownership extension to be a GitHub icon and the word Owners and the owners are displayed on hover in the tooltip.
  • Change the Sentry button to be the logo
  • Change the Codecov button to be the logo

2) Adjust styling to accommodate for button overflow.

browser-extension bug estimat1d extensions teaweb

Most helpful comment

Note that only two of these buttons are there by default - the TypeScript toggle and the Sourcegraph button. All others are extensions that must be explicitly installed.

  • Sentry: Do we really need a button for this? Could command palette suffice? If not, lets only make it an icon.
  • CodeCov: Could we make it only show the percentage, and use the CodeCov logo? 鈽傦笍
  • Code Owners: This one is a big offender. No good ideas here, but also, it is not really a button, just a display. Imo this information should not be contributed through a button in the toolbar but somewhere else.

We should make the toolbar not break so badly though.

All 3 comments

Note that only two of these buttons are there by default - the TypeScript toggle and the Sourcegraph button. All others are extensions that must be explicitly installed.

  • Sentry: Do we really need a button for this? Could command palette suffice? If not, lets only make it an icon.
  • CodeCov: Could we make it only show the percentage, and use the CodeCov logo? 鈽傦笍
  • Code Owners: This one is a big offender. No good ideas here, but also, it is not really a button, just a display. Imo this information should not be contributed through a button in the toolbar but somewhere else.

We should make the toolbar not break so badly though.

  • Sentry: Do we really need a button for this? Could command palette suffice? If not, lets only make it an icon.

It is now just an icon (see screenshot below). I'd like to have a general command palette discussion in the near future to get me up to speed on intention, vision, limitations, etc.

  • CodeCov: Could we make it only show the percentage, and use the CodeCov logo? 鈽傦笍

I like this - let's do it.

  • Code Owners: This one is a big offender. No good ideas here, but also, it is not really a button, just a display. Imo this information should not be contributed through a button in the toolbar but somewhere else.

+1 to this being somewhere else. Strawman: what if instead of being a "button" it is just text right aligned to right edge below the other buttons and makes the header "thicker"?

PR:
image

File view:
image

Tentatively prioritizing for 3.15 cc @christinaforney @imtommyroberts

Was this page helpful?
0 / 5 - 0 ratings