Slack: Subscribed to whole organization, Slack only picks up commits for the master branch.

[iLemon]

[welcome[bot]]

Thanks for opening this issue! If you would like to help implement an improvement, read more about contributing and consider submitting a pull request.

[justinperkins]

Correction to the title of this issue: "only picks up commits to the _default_ branch"

After wrestling with this app for an hour plus and feeling pretty frustrated at how much of a step back in time this feels from the days of "legacy slack integrations", I can't heart this issue enough.

From an organizational perspective, this app does everything wrong by default.

What I want: slack messages for anything that happens to any repo (including future repos) in my organization.

How to get it:

1. Add github app to slack
2. Invite github to channel
3. Subscribe github to organization with a long list of all the things you care about, aka: /github subscribe <org> issues pulls statuses commits deployments public releases reviews comments branches commits:all

If you follow the README, which says that most of that is enabled by default (it's not), you will end up bald and upset like me.

[izuzak]

If you follow the README, which says that most of that is enabled by default (it's not), you will end up bald and upset like me.

Hey, @justinperkins 👋 I just tried reproducing this problem, but wasn't able to. I ran /github subscribe <org> in a brand new channel, and then created an issue in one of the org's repos, and a notification showed up in Slack for that issue. Closing and reopening a pull request also showed a notification. With that in mind, it seems to me that the subscription indeed is subscribed to those events by default, not just to pushes on the master branch.

@justinperkins Could you perhaps try reproducing this again and sending the details over to [email protected] so that we can investigate?

@iLemon 👋 can you clarify what you mean by your issue (there's no body with a more detailed description so I'm not sure)? Did you expect that the subscription would be active for all branches? If so, then that's not the case and is expected+documented behavior (see https://github.com/integrations/slack#configuration).

[justinperkins]

@izuzak You will not get commit notifications on branches until you explicitly tell the GitHub app you want to see them. That's the main issue here (see Issue title).

[izuzak]

@izuzak You will not get commit notifications on branches until you explicitly tell the GitHub app you want to see them. That's the main issue here (see Issue title).

@justinperkins I'm not sure I'm following. Is this being pointed out as a bug or as a feature request? If I understood what you're saying correctly, then the behavior you described is expected and documented:

https://github.com/integrations/slack#configuration

So, by default you get notifications for commits on the default branch. If you want to get notification on other branches, you need to subscribe for them explicitly:

[justinperkins]

@izuzak This isn't my Issue, I just stumbled upon it last night when this Slack app was driving me up the wall. I guess I would call it a feature request. For subscribing to organizations. I personally find the default behavior not at all what we want.

[izuzak]

This isn't my Issue, I just stumbled upon it last night when this Slack app was driving me up the wall. I guess I would call it a feature request.

Thanks for clarifying, @justinperkins. :bow: Yeah, I understand that you didn't open this issue -- that's why I initially directed the question at @iLemon (who opened the issue) and didn't expect you to answer it.

The question I wanted to ask you was related to what you said here:

"If you follow the README, which says that most of that is enabled by default (it's not), you will end up bald and upset like me."

As far as I can tell, that's not true. As far as I can tell, the things that are listed as enabled by default are really enabled by default. Are you able to reproduce the problem and if so -- which events are not enabled by default for you but are listed as enabled by default? Again, please feel free to followup with us via [email protected] with specific details.

For subscribing to organizations. I personally find the default behavior not at all what we want.

What would you like the default behavior to be? Would it be to subscribe to all available events?

Thanks again for taking the time to share feedback!

[justinperkins]

What would you like the default behavior to be?

Commit & branch notifications on all repos, present and future.

[izuzak]

Commit & branch notifications on all repos, present and future.

@justinperkins By this you mean the equivalent of subscribing only to the commits:all and branches events, as documented here, correct? Not to any other events?

[brunolemos]

I can reproduce the issue reported by OP @iLemon when subscribing to the facebook organization. It only sends commits to the slack, doesn't send any issue, for example. It's probably related to permissions not enabled.

It works as expected for my own organization devhubapp, I can see issues and pull requests.

[tedivm]

Wow, I didn't even know subscribing to entire orgs was possible because the "help" message that shows up doesn't show it as an option.

[izuzak]

I can reproduce the issue reported by OP @iLemon when subscribing to the facebook organization. It only sends commits to the slack, doesn't send any issue, for example. It's probably related to permissions not enabled.

@brunolemos I just tried subscribing to the facebook organization and observed other events as well, not just commits. Here's a screenshot:

Perhaps you didn't wait long enough for a non-commit event to happen?

Also, which permissions exactly are you referring to when you say "It's probably related to permissions not enabled." and where/how are they enabled/disabled?

[redders6600]

My experience (with a public channel) was that when I did /github subscribe owner/repo I wasn't getting notifications for most things - I didn't commit to master during that time, but did create issues, etc.

I have now manually subscribe to everything, and it's working as expected, but there was no indication that my subscription was limited.

Personally I think that at least /github subscribe list should tell you the scopes it's subscribed to, so it doesn't just feel like it's broken with no explanation at all.

_For me_, the expected behaviour was that by default it would subscribe to _everything_ for that repo.

[brunolemos]

@izuzak I think I understood the issue now. It's because I was expecting to receive activities from all facebook repositories, but it seems the slack integration was only installed on a couple repos (like this hvvm, which is the same one I was receiving activities from. may be the only one).

_UX for this could be improved. Maybe showing that the org has enabled the integration for X repos?_

_Related thought: As a GitHub App developer, I wish I could subscribe to webhooks from public orgs/repos even if they don't have the app installed. Would help with this case, for example._

[brunolemos]

@redders6600 you can use /github subscribe list features now

[izuzak]

Thanks for confirming, @brunolemos :bow:. I'm going to close this out since we've confirmed that events which should be delivered indeed are delivered. As for expanding the set of default events -- I think that should be covered by a different issue / feature request.

UX for this could be improved. Maybe showing that the org has enabled the integration for X repos?

@brunolemos please feel free to add this feedback in related existing issues or open a new issue. 👍

[BashCloud]

Seems like particular feature changed from commits:all to commits:*

Issue can still be marked closed, writing here for quick resolution for others.
In short, this worked for me:

/github subscribe <org> commits:*