Slack: Show build status with commit notification

[xt0rted]

If I create a PR two messages show up in slack, one about the PR being opened and another showing the build status of the PR. Once the build is finished the status is updated accordingly. If I then push more changes to this branch the build status doesn't change to pending/success/failed, and no new message comings in showing the new build that's currently going. It'd be nice to see the most recent build/check statuses after a new push.

[bkeepers]

Hi @xt0rted, thanks for open an issue.

The behavior you're seeing is actually intentional. We only update messages for the first 30 minutes after they are posted. I opened an issue to remind us to document this and explain our rationale, but the TL;DR is we wanted to rollup related activity without generating more noise, but also wanted the history to reflect reality at the time. For example, it would be confusing to look back at a discussion about why the build was failing if the notification was later updated to passing.

I think it would make sense to include build status on the commits and commits:all notifications so statuses are shown whenever commits are pushed.

I updated the title of this issue to reflect that direction. Let me know if you have any feedback on that.

[xt0rted]

Showing statuses along with later commits/pushes is what I was envisioning. A lot of times I'll create a PR and continue pushing to it (sometimes over multiple days), so seeing those later statuses is really useful. How would this work if I rebased and force pushed? Would there be a notification & status message for that as well?

[bkeepers]

How would this work if I rebased and force pushed? Would there be a notification & status message for that as well?

Yeah, I think we would show statuses whenever commits were pushed.

[stale[bot]]

Is this still relevant? If so, just comment with any updates and we'll leave it open. Otherwise, if there is no further activity, it will be closed.